Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not prevent native console log #70

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

maxpatiiuk
Copy link

Related to

See #61

Notes

In the above issue I advocated for not capturing the log messages, letting them through naturally.
Then, I proposed two options:

  • After the test is complete, throw error saying that console messages appeared - this is implemented in feat: do not capture log messages #69
  • After the test is complete, throw error saying that console messages appeared, and print the messages again - this PR implements this approach

Types of changes

  • 🐛 Bug fix
  • 💥 Breaking change
  • ✨ New feature
  • ♻️ Refactoring
  • 📖 Documentation

Maintainability & Security

  • Verified that unit tests in this package are passing
  • Verified this branch of vitest-fail-on-console on my personal vitest node.js and vitest browser tests to make sure it works correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant