Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix errors with Rate Limiting lab #18

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gbengataylor
Copy link

@gbengataylor gbengataylor commented Jan 21, 2020

Problem 1:

Before Starting Section -
In the previous lab, the destination rule for the recommendation was deleted so when the user runs

oc -n user1-tutorial get istio-io

It won't include the destination rule like the guide says

Problem 2:

Rate Limiting Section -
The istio resources are created in the -scmp folder, rather than the -tutorial folder and as a result the lab doesn't work. For example, the current script for user1 is

sed -e "s/USERNAME/$JUPYTERHUB_USER/" /opt/app-root/workshop/content/src/istiofiles/recommendation_rate_limit.yml \
| oc create -n user1-smcp -f -

it should be

sed -e "s/USERNAME/$JUPYTERHUB_USER/" /opt/app-root/workshop/content/src/istiofiles/recommendation_rate_limit.yml \
| oc create -n user1-tutorial -f -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant