Web eid compat changes #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: LegacyIdentificationManager is now exported from the helper library too. This is to be used when interfacing with the deprecated actions based api of django-esteid
Changed:
getCertificatenow returns DER encoded certificate instead of its HEX representation. This is due to the change in the upstream extension.Changed: IDCardManager's
certificateis now a DER encoded certificate string instead of a certificate instance with encoded/hex fields.Added: IDCardManager now has a new instance field
supportedSignatureAlgorithmswhich is populated with the supported signature algorithms from the certificate during a signing session (its available after a successful call togetCertificate).Changed:
IdentificationManager.getErrornow expects the entire error object as its argument instead of only the error message valueChanged: Build system is now esbuild instead of webpack 4