Implement Waybiller client #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Live waybiller does not validate some of the data that waybiller responds with.
iharthi
force-pushed
the
initial-client
branch
3 times, most recently
from
506bacc to
210803d
Compare
Makes mypy happier
iharthi
force-pushed
the
initial-client
branch
from
8a0eaf5 to
e893009
Compare
AlekefromKz
suggested changes
Nov 8, 2023
|
Currently, it uses the staging server to generate schema Potentially it might cause issues if staging has a different schema from live, is it a problem? Probably not a problem that we reveal the staging server to public |
|
Could you please explain the pipeline, don't have much experience with packages Let's say WB adds a new endpoint to add comments to waybills Then we would need to regenerate the client, and release it with a newer version, right? And then use that version in the projects where this package is used |
Pretty much what you wrote. Once Waybiller schema changes, things may break, usually in couple of ways:
|
iharthi
force-pushed
the
initial-client
branch
from
e893009 to
ded38ca
Compare
AlekefromKz
approved these changes
Nov 8, 2023
Add manual test command to test against waybiller data dump. Run manual test for waybills (list and detail) and fix any issues that cause real data from waybiller to not validate with the schema.
Waybiller schema has origin_id mistakenly using optional int, while in reality it is a mapped id which is optional string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by pyEVR package with similar purpose, extracted from some of the projects where we already used this.