This repository was archived by the owner on Mar 3, 2020. It is now read-only.
Don't strip unless the result if non-nil. #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…this case specific.
…hat follow from passing.
|
I can rebase and squash once you review; just wanted to leave the test fixes separate so it was clear what changes I made. |
jkrall
added a commit
to jkrall/capybara-webkit
that referenced
this pull request
Jul 15, 2011
Alleviated issue thoughtbot#66 for me (builds on what was done in thoughtbot#108)
|
@mike-burns what problems are you having with the tests? |
|
Well they seem to be passing now so, merged! |
|
Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't strip the result if it comes back as nil, as it will throw an exception before capybara-webkit can throw a WebkitError.
Continuation of #105, as it was accidentally closed. This updates the tests to ensure that once the socket is unstubbed the following tests have a clean slate to continue testing on by stubbing out all writes to the socket.