Skip to content

Commit

Permalink
Update README.md (update EnvFactoryRegistered params) (#1228)
Browse files Browse the repository at this point in the history
To initiate a EnvFactoryRegistered, we now need `train_seed=0` and
`test_seed=0` arguments passed instead of `seed` previously written in
documentation code snippet.

- [x] I have added the correct label(s) to this Pull Request or linked
the relevant issue(s)
- [x] I have provided a description of the changes in this Pull Request
- [x] I have added documentation for my changes and have listed relevant
changes in CHANGELOG.md
- [x] If applicable, I have added tests to cover my changes.
- [x] I have reformatted the code using `poe format` 
- [x] I have checked style and types with `poe lint` and `poe
type-check`
- [x] (Optional) I ran tests locally with `poe test` 
(or a subset of them with `poe test-reduced`) ,and they pass
- [x] (Optional) I have tested that documentation builds correctly with
`poe doc-build`
  • Loading branch information
konnovdev authored Dec 9, 2024
1 parent 7a2bbe5 commit 2463f8b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ almost exclusively concerned with configuration that controls what to do
```python
experiment = (
DQNExperimentBuilder(
EnvFactoryRegistered(task="CartPole-v1", seed=0, venv_type=VectorEnvType.DUMMY),
EnvFactoryRegistered(task="CartPole-v1", train_seed=0, test_seed=0, venv_type=VectorEnvType.DUMMY),
ExperimentConfig(
persistence_enabled=False,
watch=True,
Expand Down

0 comments on commit 2463f8b

Please sign in to comment.