Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3] SbsaQemu-rme: Add support for SBSA-rme platform #243

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

mathieupoirier
Copy link
Contributor

Hi Maintainers,

Please find herein the second revision of this set. Following our converstion from the first iteration, I am using a command line flag to enable RME support. I also took the initiative of adding some documentation to avoid having to look in the configuration files to remember the exact command line option to use.

Thanks for the time,
Mathieu

Platform/Qemu/SbsaQemu/SbsaQemu.dsc Outdated Show resolved Hide resolved
Platform/Qemu/SbsaQemu/Readme.md Show resolved Hide resolved
Platform/Qemu/SbsaQemu/SbsaQemu.dsc Show resolved Hide resolved
Platform/Qemu/SbsaQemu/SbsaQemu.fdf Outdated Show resolved Hide resolved
@tianocore-assign-reviewers tianocore-assign-reviewers bot removed the request for review from lgao4 November 25, 2024 21:07
@mathieupoirier mathieupoirier changed the title [V2] SbsaQemu-rme: Add support for SBSA-rme platform [V3] SbsaQemu-rme: Add support for SBSA-rme platform Nov 25, 2024
Platform/Qemu/SbsaQemu/SbsaQemu.dsc Outdated Show resolved Hide resolved
@hrw
Copy link
Contributor

hrw commented Nov 26, 2024

One change to make and ready to merge.

Add support for SbsaQemuRme platform by 1) pushing the start of the base
memory to 0x10043000000 to make room to the RMM and 2) increasing the
size of FLASH0 to accomotate the RMM.

Enabling RMM is done by specifying -D ENABLE_RME on the build command
line.  The name of the flag was chosen to reflect what is currently done
on TF-A.

Signed-off-by: Mathieu Poirier <[email protected]>
Copy link
Contributor

@hrw hrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applies, builds, works.

LGTM.

@ardbiesheuvel ardbiesheuvel merged commit 65e64c0 into tianocore:master Nov 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants