Skip to content

emojilingo: support for MS emojis + defaulting to English + more inline comments #3036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cedricsam
Copy link
Contributor

  • adding support for Microsoft emojis (there are 1565 valid ones in English)
  • changing default language to English (to make it more appealing to an international audience -- was Canadian French before)
  • inline comments providing some context in the source code

@tidbyt
Copy link

tidbyt bot commented May 7, 2025

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of cache.star requires review
Original Author The original author matches the PR author

@cedricsam cedricsam force-pushed the emojilingo-microsoft-emojis branch from e023737 to 9625f6f Compare May 7, 2025 04:40
@cedricsam
Copy link
Contributor Author

To spot check the MS emojis, you can change the default vendor locally to microsoft and let the randomizer pick emojis or pick one from the full-emoji-list with their number ( / the first column) set for the variable test_emoji in emoji_lingo.star.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant