rework error messages #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topepo
commented
Oct 18, 2024
R/checks.R
Outdated
| is_d_input <- function(x) { | ||
| tmp <- purrr::map(x, check_numeric, input = "desirability") | ||
| tmp <- purrr::map(x, check_unit_range) | ||
| is_d_input <- function(x, call) { |
There was a problem hiding this comment.
The next PR will use a constructor to check these things and give the desirability vectors classes c("numeric", "desirability") without going full vctrs.
That will make these checks a lot easier/better. The current method would let something like roc_auc in without an error.
simonpcouch
reviewed
Oct 21, 2024
| if (!is.vector(x) || !is.numeric(x)) { | ||
| rlang::abort(paste0(input, " should be a numeric vector.")) | ||
| cli::cli_abort("{.arg {input}} should be {an} numeric vector.") |
There was a problem hiding this comment.
This substitution will raise an error, as there's no an in the fn environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to testing with:
expect_snapshot_error()converted toexpect_snapshot(..., error = TRUE)