Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test show_best(), select_best(), and select_by_*() for survival models #118

Closed
3 tasks done
hfrick opened this issue Nov 9, 2023 · 0 comments
Closed
3 tasks done

Test show_best(), select_best(), and select_by_*() for survival models #118

hfrick opened this issue Nov 9, 2023 · 0 comments
Assignees
@topepo

Comments

@hfrick
Copy link
Member

hfrick commented Nov 9, 2023 •
edited by topepo
Loading

Many other PRs have affected these (esp improving the text in warnings and errors)
@hfrick hfrick mentioned this issue Nov 9, 2023
Closed
30 tasks
@hfrick hfrick changed the title Test show_best(), select_best(), and select_by_*()` for survival models Test show_best(), select_best(), and select_by_*() for survival models Nov 9, 2023
@topepo topepo self-assigned this Nov 10, 2023
topepo pushed a commit that referenced this issue Dec 18, 2023
initial tests for #118
19e963e
@topepo topepo mentioned this issue Dec 18, 2023
Merged
topepo added a commit that referenced this issue Jan 17, 2024
@topepo
unit tests for #118
23ee019
@topepo topepo mentioned this issue Jan 17, 2024
Merged
topepo added a commit that referenced this issue Jan 17, 2024
@topepo @hfrick
show_best tests for censored regression models (#156)
c7bc3bd 
* initial tests for #118

* return 5 configs

* missing %>%

* reduce changes of ties affecting results

* trying to avoid irreproducible results across runs and OS'es

* Apply suggestions from code review

Co-authored-by: Hannah Frick <[email protected]>

* update for latest tune version

* updated snapshots

* updated snapshots with new current package versions

---------

Co-authored-by: ‘topepo’ <‘[email protected]’>
Co-authored-by: Hannah Frick <[email protected]>
topepo added a commit that referenced this issue Jan 22, 2024
@topepo
survival analysis tests for the select_*() functions (#165)
176cefb 
* unit tests for #118

* update version req and snapshots for tidymodels/tune#823

---------

Co-authored-by: ‘topepo’ <‘[email protected]’>
@topepo topepo closed this as completed Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@topepo topepo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@topepo @hfrick