show_best tests for censored regression models #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hfrick After review, we can set on this PR until tidymodels/tune#781 is resolved. |
hfrick
approved these changes
Jan 2, 2024
Comment on lines
+38
to
+41
| Warning: | ||
| Metric "concordance_survival" was used to evaluate model candidates in the race but "brier_survival_integrated" has been chosen to rank the candidates. These results may not agree with the race. | ||
| Error in `show_best()`: | ||
| ! "brier_survival_integrated" was not in the metric set. Please choose from: "concordance_survival". |
There was a problem hiding this comment.
Let's just error here instead of warn about the metric and then error anyway. I'll open an issue if you agree.
There was a problem hiding this comment.
Open the issue on finetune tidymodels/finetune#89 -- this PR is ready to merge!
Co-authored-by: Hannah Frick <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial tests for #118