Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address inflation of model_stack object size after saving and reloading #216

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

simonpcouch
Copy link
Collaborator

@simonpcouch simonpcouch commented Jul 15, 2024

Closes #214.

Model stacks will still be larger after saving/reloading if not butchered, but when butchered, the saved and reloaded object will be comparable in size to the original. With this PR:

# object after reloading
lobstr::obj_size(stack_finalized)
#> 2.62 GB
# original object
lobstr::obj_size(stack_finalized_orig)
#> 1.63 GB

# butchered object after reloading
lobstr::obj_size(stack_finalized_butchered)
#> 48.59 MB
# butchered original object
lobstr::obj_size(stack_finalized_butchered_orig)
#> 47.14 MB

@simonpcouch simonpcouch merged commit 2aacf23 into main Jul 15, 2024
9 of 10 checks passed
@simonpcouch simonpcouch deleted the size-214 branch July 15, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reduce size of final model_stack for making predictions
1 participant