-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: manual pages for select()
and mutate()
#351
Conversation
… and dplyr are loaded
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 6e757c9 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
That won't fly, unfortunately. Looks like if we want to reexport, we need to document.
https://github.com/tidyverse/duckplyr/actions/runs/11953558550/job/33321797657?pr=351#step:17:223 @hadley: Neither dbplyr nor dtplyr reexport the dplyr generics. I'm inclined to avoid reexporting here too, but to support the existing library(duckplyr)
data.frame(a = 1) |> mutate(b = 2) pattern we'd need to add |
Let's ignore the reexport question for the purpose of this PR, and focus only on providing |
Why can't you just document the methods? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks. We could add the documentation to arrange.R
instead of arrange-rd.R
if the sync scripts work, but if they don't, we can keep it as is.
@krlmlr since the main branch was merged into this I don't think I can rebase. Should I start a new branch or do you want to squash? |
#214