Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Use stingy instead of frugal #594

Merged
merged 3 commits into from
Feb 7, 2025
Merged

docs: Use stingy instead of frugal #594

merged 3 commits into from
Feb 7, 2025

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Feb 7, 2025 •
edited
Loading

No description provided.

@krlmlr krlmlr changed the title f stingy docs: Use stingy instead of frugal Feb 7, 2025
@krlmlr krlmlr enabled auto-merge (squash) February 7, 2025 03:01
@krlmlr krlmlr marked this pull request as draft February 7, 2025 03:02
auto-merge was automatically disabled February 7, 2025 03:02

Pull request was converted to draft

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 6bbfe0b is merged into main:

  • ✔️001_tpch_01: 24.2ms -> 23.4ms [-9.05%, +1.98%]
  • ✔️001_tpch_02: 63.1ms -> 63ms [-0.75%, +0.46%]
  • ✔️001_tpch_03: 39.5ms -> 38.9ms [-4.72%, +1.43%]
  • ✔️001_tpch_04: 28.1ms -> 28ms [-2.97%, +2.54%]
  • ✔️001_tpch_05: 59.8ms -> 58.9ms [-4.25%, +1.02%]
  • ✔️001_tpch_06: 11.6ms -> 11.6ms [-3.22%, +2.64%]
  • ✔️001_tpch_07: 75.1ms -> 75.3ms [-2.36%, +2.84%]
  • ✔️001_tpch_08: 105ms -> 104ms [-2.29%, +1.41%]
  • ✔️001_tpch_09: 72.9ms -> 73.7ms [-1.1%, +3.24%]
  • ✔️001_tpch_10: 47.2ms -> 47.1ms [-1.53%, +1.07%]
  • ✔️001_tpch_11: 37.5ms -> 37.5ms [-1.26%, +1.2%]
  • ✔️001_tpch_12: 21ms -> 20.9ms [-1.79%, +1.37%]
  • ✔️001_tpch_13: 18.3ms -> 17.8ms [-5.76%, +0.72%]
  • ✔️001_tpch_14: 16.5ms -> 16.7ms [-1.5%, +3.41%]
  • ✔️001_tpch_15: 36.1ms -> 36.4ms [-0.38%, +1.82%]
  • ✔️001_tpch_16: 34.9ms -> 34.8ms [-1.65%, +1.34%]
  • ✔️001_tpch_17: 30.6ms -> 30.5ms [-2.22%, +1.44%]
  • ✔️001_tpch_18: 27.6ms -> 27.3ms [-3.36%, +0.76%]
  • ✔️001_tpch_19: 37.6ms -> 37.7ms [-0.97%, +1.22%]
  • ✔️001_tpch_20: 49.3ms -> 49.6ms [-0.09%, +1.32%]
  • ✔️001_tpch_21: 78.5ms -> 78.3ms [-1.32%, +0.86%]
  • ✔️001_tpch_22: 45.1ms -> 46.5ms [-0.03%, +6.24%]
  • ✔️010_tpch_01: 83.5ms -> 85.4ms [-1.88%, +6.32%]
  • ✔️010_tpch_02: 72.1ms -> 74.6ms [-8.38%, +15.2%]
  • ✔️010_tpch_03: 57.9ms -> 58ms [-1.56%, +2.1%]
  • ✔️010_tpch_04: 43.5ms -> 42.8ms [-4.35%, +0.98%]
  • ✔️010_tpch_05: 92.5ms -> 91.7ms [-3.09%, +1.18%]
  • ✔️010_tpch_06: 29.2ms -> 30ms [-3.45%, +8.74%]
  • ✔️010_tpch_07: 102ms -> 103ms [-1.45%, +3.21%]
  • ✔️010_tpch_08: 126ms -> 126ms [-1.19%, +0.94%]
  • ✔️010_tpch_09: 115ms -> 116ms [-1.13%, +3.17%]
  • ✔️010_tpch_10: 75.8ms -> 74.8ms [-3.67%, +0.83%]
  • ✔️010_tpch_11: 38ms -> 37.6ms [-5.1%, +3.02%]
  • ✔️010_tpch_12: 49.7ms -> 51.3ms [-1.6%, +7.99%]
  • ✔️010_tpch_13: 49.7ms -> 50.6ms [-2.46%, +5.82%]
  • ✔️010_tpch_14: 33.4ms -> 34ms [-4.45%, +8.06%]
  • ✔️010_tpch_15: 52.8ms -> 52.6ms [-6.5%, +5.73%]
  • ✔️010_tpch_16: 38.3ms -> 38.2ms [-2.91%, +2.71%]
  • ✔️010_tpch_17: 53.5ms -> 55.5ms [-2.49%, +9.92%]
  • ✔️010_tpch_18: 52ms -> 55.9ms [-3.57%, +18.5%]
  • ✔️010_tpch_19: 83.6ms -> 82.9ms [-2.69%, +0.96%]
  • ✔️010_tpch_20: 64.3ms -> 63.3ms [-6.12%, +3%]
  • ✔️010_tpch_21: 250ms -> 244ms [-4.91%, +0.17%]
  • ✔️010_tpch_22: 53.8ms -> 54ms [-2.62%, +3.42%]
  • ✔️100_tpch_01: 359ms -> 368ms [-9.53%, +14.43%]
  • ✔️100_tpch_02: 125ms -> 127ms [-0.66%, +3.28%]
  • ✔️100_tpch_03: 172ms -> 173ms [-6.06%, +7.78%]
  • ✔️100_tpch_04: 149ms -> 148ms [-2.3%, +1.27%]
  • ✔️100_tpch_05: 275ms -> 268ms [-5.9%, +1.07%]
  • ✔️100_tpch_06: 89.7ms -> 99.1ms [-7.15%, +28.11%]
  • ✔️100_tpch_07: 230ms -> 229ms [-14.26%, +12.97%]
  • ✔️100_tpch_08: 267ms -> 258ms [-13.81%, +7.39%]
  • ✔️100_tpch_09: 337ms -> 356ms [-6.97%, +17.85%]
  • ✔️100_tpch_10: 206ms -> 211ms [-5.94%, +10%]
  • ✔️100_tpch_11: 82ms -> 84.9ms [-12.09%, +19.13%]
  • ✔️100_tpch_12: 177ms -> 184ms [-10.34%, +17.6%]
  • ✔️100_tpch_13: 311ms -> 302ms [-10.03%, +4.06%]
  • ✔️100_tpch_14: 110ms -> 114ms [-5.04%, +13.55%]
  • ✔️100_tpch_15: 196ms -> 193ms [-9.75%, +6.79%]
  • ✔️100_tpch_16: 121ms -> 126ms [-15.23%, +23.5%]
  • ✔️100_tpch_17: 172ms -> 178ms [-7.36%, +14.84%]
  • ✔️100_tpch_18: 185ms -> 193ms [-3.03%, +11.63%]
  • ✔️100_tpch_19: 274ms -> 271ms [-14.2%, +12.36%]
  • ✔️100_tpch_20: 173ms -> 175ms [-2.17%, +5.57%]
  • ✔️100_tpch_21: 1.33s -> 1.32s [-4.3%, +4.03%]
  • ✔️100_tpch_22: 151ms -> 151ms [-5.56%, +5.88%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@krlmlr krlmlr marked this pull request as ready for review February 7, 2025 05:06
@krlmlr krlmlr enabled auto-merge (squash) February 7, 2025 05:06
@krlmlr krlmlr disabled auto-merge February 7, 2025 05:21
@krlmlr krlmlr merged commit 097102f into main Feb 7, 2025
2 of 3 checks passed
@krlmlr krlmlr deleted the f-stingy branch February 7, 2025 05:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

This is how benchmark results would change (along with a 95% confidence interval in relative change) if d66310c is merged into main:

  • ✔️001_tpch_01: 23.6ms -> 23.4ms [-5.99%, +4.23%]
  • ✔️001_tpch_02: 63.9ms -> 63.7ms [-1.18%, +0.47%]
  • ✔️001_tpch_03: 39.2ms -> 38.9ms [-1.97%, +0.41%]
  • ❗🐌001_tpch_04: 27.1ms -> 27.8ms [+0.11%, +4.7%]
  • ✔️001_tpch_05: 56.1ms -> 56ms [-0.95%, +0.78%]
  • ✔️001_tpch_06: 11.6ms -> 12.1ms [-4.6%, +12.64%]
  • ✔️001_tpch_07: 71.6ms -> 72ms [-1.28%, +2.36%]
  • ✔️001_tpch_08: 97.3ms -> 96.7ms [-2.06%, +0.97%]
  • ✔️001_tpch_09: 67.9ms -> 67.6ms [-1.9%, +0.87%]
  • ✔️001_tpch_10: 46.3ms -> 46.2ms [-1.02%, +0.52%]
  • ✔️001_tpch_11: 37.2ms -> 36.8ms [-2.11%, +0.2%]
  • ✔️001_tpch_12: 20.6ms -> 20.8ms [-0.8%, +3.11%]
  • ✔️001_tpch_13: 18ms -> 18ms [-3.34%, +3.29%]
  • ✔️001_tpch_14: 16.9ms -> 16.4ms [-8.13%, +1.48%]
  • ✔️001_tpch_15: 36.2ms -> 36.1ms [-2.34%, +1.38%]
  • ✔️001_tpch_16: 34.7ms -> 35.1ms [-1.38%, +3.63%]
  • ✔️001_tpch_17: 30.9ms -> 30.9ms [-1.53%, +1.84%]
  • ✔️001_tpch_18: 28.5ms -> 28.9ms [-0.38%, +2.74%]
  • ✔️001_tpch_19: 38.8ms -> 38.8ms [-0.94%, +0.93%]
  • ✔️001_tpch_20: 51.9ms -> 51ms [-5.65%, +2.37%]
  • ✔️001_tpch_21: 78.8ms -> 78.9ms [-1.18%, +1.64%]
  • ✔️001_tpch_22: 45.3ms -> 45.3ms [-0.71%, +0.79%]
  • ✔️010_tpch_01: 85.6ms -> 83.6ms [-5.96%, +1.4%]
  • ✔️010_tpch_02: 70.2ms -> 71.3ms [-1.71%, +5.06%]
  • ✔️010_tpch_03: 57.5ms -> 57.5ms [-2.38%, +2.46%]
  • ✔️010_tpch_04: 43.8ms -> 44.4ms [-6.68%, +9.54%]
  • ✔️010_tpch_05: 90.4ms -> 90.4ms [-2.54%, +2.43%]
  • ✔️010_tpch_06: 29.4ms -> 29.5ms [-6.98%, +8%]
  • ✔️010_tpch_07: 102ms -> 104ms [-1.11%, +5.68%]
  • ✔️010_tpch_08: 127ms -> 128ms [-1.41%, +2.72%]
  • ✔️010_tpch_09: 116ms -> 117ms [-2.74%, +3.87%]
  • ✔️010_tpch_10: 74.7ms -> 73.9ms [-2.88%, +0.52%]
  • ✔️010_tpch_11: 38.9ms -> 37.9ms [-6.9%, +1.57%]
  • ✔️010_tpch_12: 51.2ms -> 51.4ms [-1.48%, +2.58%]
  • ✔️010_tpch_13: 51.4ms -> 50.9ms [-3.04%, +1.1%]
  • ✔️010_tpch_14: 33.5ms -> 33.9ms [-0.84%, +2.91%]
  • ✔️010_tpch_15: 53.3ms -> 53.4ms [-6.75%, +7.26%]
  • ✔️010_tpch_16: 39.5ms -> 39.7ms [-7.02%, +7.81%]
  • ✔️010_tpch_17: 52.9ms -> 53.1ms [-3.84%, +4.83%]
  • ✔️010_tpch_18: 50.9ms -> 53.2ms [-5.2%, +13.88%]
  • ✔️010_tpch_19: 83.8ms -> 85.6ms [-1.12%, +5.34%]
  • ✔️010_tpch_20: 65.9ms -> 65.3ms [-6.32%, +4.57%]
  • ✔️010_tpch_21: 248ms -> 245ms [-3.79%, +1.34%]
  • ✔️010_tpch_22: 53.4ms -> 55.9ms [-1.14%, +10.39%]
  • 🚀100_tpch_01: 364ms -> 326ms [-18.32%, -2.45%]
  • ✔️100_tpch_02: 126ms -> 125ms [-9.04%, +7.46%]
  • ✔️100_tpch_03: 173ms -> 174ms [-3.01%, +4.71%]
  • ✔️100_tpch_04: 150ms -> 153ms [-0.53%, +4.33%]
  • ✔️100_tpch_05: 270ms -> 256ms [-10.71%, +0.32%]
  • ✔️100_tpch_06: 96.1ms -> 101ms [-8.07%, +18.29%]
  • ✔️100_tpch_07: 219ms -> 225ms [-6.78%, +11.93%]
  • ✔️100_tpch_08: 264ms -> 261ms [-9.2%, +6.55%]
  • ✔️100_tpch_09: 341ms -> 346ms [-10.47%, +13.1%]
  • ✔️100_tpch_10: 212ms -> 203ms [-17.13%, +8.77%]
  • ✔️100_tpch_11: 81.8ms -> 82.3ms [-3.38%, +4.62%]
  • ✔️100_tpch_12: 179ms -> 185ms [-10.91%, +17.57%]
  • ✔️100_tpch_13: 303ms -> 301ms [-5.18%, +4.05%]
  • ✔️100_tpch_14: 116ms -> 113ms [-15.13%, +10.06%]
  • ✔️100_tpch_15: 207ms -> 199ms [-8.44%, +1.18%]
  • ✔️100_tpch_16: 123ms -> 124ms [-10.09%, +11.05%]
  • ✔️100_tpch_17: 171ms -> 180ms [-10.46%, +20.9%]
  • ❗🐌100_tpch_18: 185ms -> 200ms [+2.17%, +14.39%]
  • ✔️100_tpch_19: 269ms -> 266ms [-25.17%, +22.79%]
  • ✔️100_tpch_20: 170ms -> 170ms [-7.34%, +8.15%]
  • ✔️100_tpch_21: 1.3s -> 1.34s [-8.06%, +13.87%]
  • ✔️100_tpch_22: 150ms -> 157ms [-4.92%, +14.66%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@krlmlr