Polish decorator implementation a litte #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly just so I understand how it works.
hadley
commented
Sep 16, 2024
| } | ||
| # Must use elmer::: because the lexical environment of this function is | ||
| # about to get wrecked by R6 | ||
| gen_method <- new_function(args_def, |
There was a problem hiding this comment.
This is probably overkill since they're private methods, but this matches the actual argument names rather than relying on ....
|
Might be tricky merging this with #17, sorry. |
|
Is this something you want to come back to? |
|
Yeah, I'll re-apply when I next have a minute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just so I understand how it works.