Improve support for temporary IAM credentials in chat_bedrock() #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't been able to a real test of this yet. Should maybe hold off on merging until then. |
|
It does feel like maybe httr2 could provide some generic interface for this (i.e. some callback that determines if an error response was due to an out of date token, and another function that updates that token?) |
|
A lot of the pieces are already there with |
|
I wonder if you can abuse |
atheriel
force-pushed
the
aws-credential-refresh
branch
from
6037b07 to
66d0137
Compare
hadley
approved these changes
Jan 24, 2025
Many AWS IAM credentials expire, but previously we ignored this by looking up credentials only once, in `chat_bedrock()`. This commit introduces a caching layer that handles expiry and moves credential retrieval closer to request time, instead. The design is almost identical to httr2's OAuth token caching mechanism, but I had to re-implement various pieces because not all of that API is exported. (We could probably introduce a `req_aws_credentials()` function to `httr2` itself that would handle this, but that might tie us too closely to the semantics of `paws.common`.) Unit tests are included. Closes #261. Signed-off-by: Aaron Jacobs <[email protected]>
atheriel
force-pushed
the
aws-credential-refresh
branch
from
66d0137 to
1ce004a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many AWS IAM credentials expire, but previously we ignored this by looking up credentials only once, in
chat_bedrock(). This commit introduces a caching layer that handles expiry and moves credential retrieval closer to request time, instead.The design is almost identical to httr2's OAuth token caching mechanism, but I had to re-implement various pieces because not all of that API is exported.
(We could probably introduce a
req_aws_credentials()function tohttr2itself that would handle this, but that might tie us too closely to the semantics ofpaws.common.)Unit tests are included.
Closes #261.