Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boilerplate functions #6143

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
5f067c1
write boilerplate function
teunbrand Oct 16, 2024
32a4a76
adopt boilerplate where possible
teunbrand Oct 16, 2024
3eee99f
write out all non-standard arguments
teunbrand Oct 17, 2024
26f9f8f
automatically fill in parameters
teunbrand Oct 17, 2024
8c8f795
incorporate small checks
teunbrand Oct 17, 2024
fa9f6d2
document
teunbrand Oct 17, 2024
075ea86
accept visual snapshots
teunbrand Oct 17, 2024
ea57200
Update R/boilerplates.R
teunbrand Oct 18, 2024
6b44f33
Adopt advice from June
teunbrand Oct 18, 2024
6e71e1a
docfix
teunbrand Oct 18, 2024
d488de8
Apply suggestions from code review
teunbrand Oct 18, 2024
e6db72d
ensure `list2()` can be found
teunbrand Oct 21, 2024
8c33474
rename `boilerplate()` to `make_constructor()`
teunbrand Oct 22, 2024
c11c5ed
give body pretty braces
teunbrand Oct 22, 2024
44cf2dc
purge unused parameters in `stat_bin()`
teunbrand Oct 22, 2024
cd54bfb
add Stat method for `make_constructor()`
teunbrand Nov 28, 2024
4dd78b5
use the `make_constructor()` for Stats
teunbrand Nov 28, 2024
c7abdd7
revert 4dd78b5c for `layer_sf()` stats
teunbrand Nov 28, 2024
d1043b0
mechanism to hide internal variables
teunbrand Nov 28, 2024
a68e4bb
document
teunbrand Nov 28, 2024
6f452f4
resolve merge conflict
teunbrand Nov 28, 2024
6c95f24
make GeomCol parent of `geom_col()` again for error message purposes
teunbrand Nov 28, 2024
52e66f2
rebalance omissions
teunbrand Nov 28, 2024
295e36c
resolve merge conflict
teunbrand Feb 4, 2025
c7aa7fd
include example of `checks` argument
teunbrand Feb 4, 2025
23f4c71
Hide origin/right arguments that are deprecated
teunbrand Feb 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ Collate:
'geom-.R'
'annotation-custom.R'
'annotation-logticks.R'
'scale-type.R'
'layer.R'
'boilerplates.R'
'geom-polygon.R'
'geom-map.R'
'annotation-map.R'
Expand Down Expand Up @@ -134,12 +137,14 @@ Collate:
'geom-abline.R'
'geom-rect.R'
'geom-bar.R'
'geom-tile.R'
'geom-bin2d.R'
'geom-blank.R'
'geom-boxplot.R'
'geom-col.R'
'geom-path.R'
'geom-contour.R'
'geom-point.R'
'geom-count.R'
'geom-crossbar.R'
'geom-segment.R'
Expand All @@ -159,15 +164,13 @@ Collate:
'geom-jitter.R'
'geom-label.R'
'geom-linerange.R'
'geom-point.R'
'geom-pointrange.R'
'geom-quantile.R'
'geom-rug.R'
'geom-sf.R'
'geom-smooth.R'
'geom-spoke.R'
'geom-text.R'
'geom-tile.R'
'geom-violin.R'
'geom-vline.R'
'ggplot2-package.R'
Expand All @@ -186,7 +189,6 @@ Collate:
'guide-colorbar.R'
'guide-colorsteps.R'
'guide-custom.R'
'layer.R'
'guide-none.R'
'guide-old.R'
'guides-.R'
Expand Down Expand Up @@ -236,7 +238,6 @@ Collate:
'scale-shape.R'
'scale-size.R'
'scale-steps.R'
'scale-type.R'
'scale-view.R'
'scale-viridis.R'
'scales-.R'
Expand Down
2 changes: 2 additions & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ S3method(as.data.frame,mapped_discrete)
S3method(as.list,ggproto)
S3method(autolayer,default)
S3method(autoplot,default)
S3method(boilerplate,Geom)
S3method(c,mapped_discrete)
S3method(drawDetails,zeroGrob)
S3method(element_grob,element_blank)
Expand Down Expand Up @@ -297,6 +298,7 @@ export(autolayer)
export(autoplot)
export(benchplot)
export(binned_scale)
export(boilerplate)
export(borders)
export(calc_element)
export(check_device)
Expand Down
122 changes: 122 additions & 0 deletions R/boilerplates.R
Original file line number Diff line number Diff line change
@@ -0,0 +1,122 @@
#' @include layer.R
#' @include scale-type.R
NULL

#' Produce boilerplate constructors
#'
#' The `boilerplate()` functions sets up a user-facing constructor for ggproto
#' classes. Currently, `boilerplate()` is implemented for `Geom` classes.
#'
#' @param x An object to setup a constructor for.
#' @param ... Name-value pairs to use as additional arguments in the
#' constructor. For layers, these are passed on to [`layer(params)`][layer()].
#' @param checks A list of calls to be evaluated before construction of the
#' object, such as one constructed with [`exprs()`][rlang::exprs()].
#' @param env An environment to search for the object.
#'
#' @return A function
#' @export
#' @keywords internal
#'
#' @examples
#' # For testing purposes, a geom that returns grobs
#' GeomTest <- ggproto(
#' "GeomTest", Geom,
#' draw_group = function(..., grob = grid::pointsGrob()) {
#' return(grob)
#' }
#' )
#' # Creating a constructor
#' geom_test <- boilerplate(GeomTest)
#'
#' # Note that `grob` is automatically an argument to the function
#' names(formals(geom_test))
#'
#' # Use in a plot
#' set.seed(1234)
#' p <- ggplot(mtcars, aes(disp, mpg))
#' p + geom_test()
#' p + geom_test(grob = grid::circleGrob())
boilerplate <- function(x, ...) {
UseMethod("boilerplate")

Check warning on line 41 in R/boilerplates.R

View check run for this annotation

Codecov / codecov/patch

R/boilerplates.R#L41

Added line #L41 was not covered by tests
}

#' @export
#' @rdname boilerplate
boilerplate.Geom <- function(x, ..., checks = NULL, env = caller_env()) {

# Check that we can independently find the geom
geom <- gsub("^geom_", "", snake_class(x))
check_subclass(geom, "Geom", env = env)

Check warning on line 50 in R/boilerplates.R

View check run for this annotation

Codecov / codecov/patch

R/boilerplates.R#L49-L50

Added lines #L49 - L50 were not covered by tests

# Split additional arguments into required and extra ones
args <- enexprs(...)
fixed_fmls_names <- c("mapping", "data", "stat", "position", "...",
"na.rm", "show.legend", "inherit.aes")
extra_args <- setdiff(names(args), fixed_fmls_names)
if ("geom" %in% extra_args) {
cli::cli_abort("{.arg geom} is a reserved argument.")

Check warning on line 58 in R/boilerplates.R

View check run for this annotation

Codecov / codecov/patch

R/boilerplates.R#L53-L58

Added lines #L53 - L58 were not covered by tests
}

# Fill in values for parameters from draw functions
known_params <-
unique(c(names(args), fixed_fmls_names, "flipped_aes", x$aesthetics()))
missing_params <- setdiff(x$parameters(), known_params)
if (length(missing_params) > 0) {
draw_args <- ggproto_formals(x$draw_panel)
if ("..." %in% names(draw_args)) {
draw_args <- ggproto_formals(x$draw_group)

Check warning on line 68 in R/boilerplates.R

View check run for this annotation

Codecov / codecov/patch

R/boilerplates.R#L62-L68

Added lines #L62 - L68 were not covered by tests
}
params <- intersect(missing_params, names(draw_args))
extra_args <- c(extra_args, params)
for (param in params) {
if (!identical(draw_args[[param]], quote(expr = ))) {
args[param] <- draw_args[param]

Check warning on line 74 in R/boilerplates.R

View check run for this annotation

Codecov / codecov/patch

R/boilerplates.R#L70-L74

Added lines #L70 - L74 were not covered by tests
}
}
missing_params <- setdiff(missing_params, names(args))
if (length(missing_params) > 0) {
cli::cli_warn(
"In {.fn geom_{geom}}: please consider providing default values for: \\
{missing_params}."
)

Check warning on line 82 in R/boilerplates.R

View check run for this annotation

Codecov / codecov/patch

R/boilerplates.R#L77-L82

Added lines #L77 - L82 were not covered by tests
}
}

# Build function formals
fmls <- pairlist2(
mapping = args$mapping,
data = args$data,
stat = args$stat %||% "identity",
position = args$position %||% "identity",
`...` = missing_arg(),
!!!args[extra_args],
na.rm = args$na.rm %||% FALSE,
show.legend = args$show.legend %||% NA,
inherit.aes = args$inherit.aes %||% TRUE
)

Check warning on line 97 in R/boilerplates.R

View check run for this annotation

Codecov / codecov/patch

R/boilerplates.R#L87-L97

Added lines #L87 - L97 were not covered by tests

# Construct call for the 'layer(params)' argument
params <- exprs(!!!syms(c("na.rm", extra_args)), .named = TRUE)
params <- call2("list2", !!!params, quote(...))

Check warning on line 101 in R/boilerplates.R

View check run for this annotation

Codecov / codecov/patch

R/boilerplates.R#L100-L101

Added lines #L100 - L101 were not covered by tests

# Construct rest of 'layer()' call
layer_args <- syms(setdiff(fixed_fmls_names, c("...", "na.rm")))
layer_args <- append(layer_args, list(geom = geom), after = 2)
layer_args <- exprs(!!!layer_args, params = !!params, .named = TRUE)
body <- call2("layer", !!!layer_args)

Check warning on line 107 in R/boilerplates.R

View check run for this annotation

Codecov / codecov/patch

R/boilerplates.R#L104-L107

Added lines #L104 - L107 were not covered by tests

# Prepend any checks
if (!missing(checks)) {
lang <- vapply(checks, is_call, logical(1))
if (!all(lang)) {
cli::cli_abort(
"{.arg checks} must be a list of calls, such as one constructed \\
with {.fn rlang::exprs}."
)

Check warning on line 116 in R/boilerplates.R

View check run for this annotation

Codecov / codecov/patch

R/boilerplates.R#L110-L116

Added lines #L110 - L116 were not covered by tests
}
body <- inject(quote(`{`(!!!c(checks, body))))

Check warning on line 118 in R/boilerplates.R

View check run for this annotation

Codecov / codecov/patch

R/boilerplates.R#L118

Added line #L118 was not covered by tests
}

new_function(fmls, body)

Check warning on line 121 in R/boilerplates.R

View check run for this annotation

Codecov / codecov/patch

R/boilerplates.R#L121

Added line #L121 was not covered by tests
}
111 changes: 45 additions & 66 deletions R/geom-bar.R
Original file line number Diff line number Diff line change
@@ -1,3 +1,45 @@
#' @rdname ggplot2-ggproto
#' @format NULL
#' @usage NULL
#' @export
#' @include geom-rect.R
GeomBar <- ggproto("GeomBar", GeomRect,
required_aes = c("x", "y"),

# These aes columns are created by setup_data(). They need to be listed here so
# that GeomRect$handle_na() properly removes any bars that fall outside the defined
# limits, not just those for which x and y are outside the limits
non_missing_aes = c("xmin", "xmax", "ymin", "ymax"),

default_aes = aes(!!!GeomRect$default_aes, width = NULL),

setup_params = function(data, params) {
params$flipped_aes <- has_flipped_aes(data, params)
params
},

extra_params = c("just", "na.rm", "orientation"),

setup_data = function(data, params) {
data$flipped_aes <- params$flipped_aes
data <- flip_data(data, params$flipped_aes)
data$width <- data$width %||%
params$width %||% (min(vapply(
split(data$x, data$PANEL, drop = TRUE),
resolution, numeric(1), zero = FALSE
)) * 0.9)
data$just <- params$just %||% 0.5
data <- transform(data,
ymin = pmin(y, 0), ymax = pmax(y, 0),
xmin = x - width * just, xmax = x + width * (1 - just),
width = NULL, just = NULL
)
flip_data(data, params$flipped_aes)
},

rename_size = TRUE
)

#' Bar charts
#'
#' There are two types of bar charts: `geom_bar()` and `geom_col()`.
Expand Down Expand Up @@ -48,6 +90,8 @@
#' @param geom,stat Override the default connection between `geom_bar()` and
#' `stat_count()`. For more information about overriding these connections,
#' see how the [stat][layer_stats] and [geom][layer_geoms] arguments work.
#' @param lineend Line end style (round, butt, square).
#' @param linejoin Line join style (round, mitre, bevel).
#' @examples
#' # geom_bar is designed to make it easy to create bar charts that show
#' # counts (or sums of weights)
Expand Down Expand Up @@ -92,69 +136,4 @@
#' ggplot(df, aes(x, y)) + geom_col(just = 0.5)
#' # Columns begin on the first day of the month
#' ggplot(df, aes(x, y)) + geom_col(just = 1)
geom_bar <- function(mapping = NULL, data = NULL,
stat = "count", position = "stack",
...,
just = 0.5,
na.rm = FALSE,
orientation = NA,
show.legend = NA,
inherit.aes = TRUE) {
layer(
data = data,
mapping = mapping,
stat = stat,
geom = GeomBar,
position = position,
show.legend = show.legend,
inherit.aes = inherit.aes,
params = list2(
just = just,
na.rm = na.rm,
orientation = orientation,
...
)
)
}

#' @rdname ggplot2-ggproto
#' @format NULL
#' @usage NULL
#' @export
#' @include geom-rect.R
GeomBar <- ggproto("GeomBar", GeomRect,
required_aes = c("x", "y"),

# These aes columns are created by setup_data(). They need to be listed here so
# that GeomRect$handle_na() properly removes any bars that fall outside the defined
# limits, not just those for which x and y are outside the limits
non_missing_aes = c("xmin", "xmax", "ymin", "ymax"),

default_aes = aes(!!!GeomRect$default_aes, width = NULL),

setup_params = function(data, params) {
params$flipped_aes <- has_flipped_aes(data, params)
params
},

extra_params = c("just", "na.rm", "orientation"),

setup_data = function(data, params) {
data$flipped_aes <- params$flipped_aes
data <- flip_data(data, params$flipped_aes)
data$width <- data$width %||%
params$width %||% (min(vapply(
split(data$x, data$PANEL, drop = TRUE),
resolution, numeric(1), zero = FALSE
)) * 0.9)
data$just <- params$just %||% 0.5
data <- transform(data,
ymin = pmin(y, 0), ymax = pmax(y, 0),
xmin = x - width * just, xmax = x + width * (1 - just),
width = NULL, just = NULL
)
flip_data(data, params$flipped_aes)
},

rename_size = TRUE
)
geom_bar <- boilerplate(GeomBar, stat = "count", position = "stack", just = 0.5)
27 changes: 6 additions & 21 deletions R/geom-bin2d.R
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
#' @include geom-tile.R
NULL

#' Heatmap of 2d bin counts
#'
#' Divides the plane into rectangles, counts the number of cases in
Expand All @@ -14,6 +17,8 @@
#' `geom_bin_2d()` and `stat_bin_2d()`. For more information about overriding
#' these connections, see how the [stat][layer_stats] and [geom][layer_geoms]
#' arguments work.
#' @param lineend Line end style (round, butt, square).
#' @param linejoin Line join style (round, mitre, bevel).
#' @seealso [stat_bin_hex()] for hexagonal binning
#' @examples
#' d <- ggplot(diamonds, aes(x, y)) + xlim(4, 10) + ylim(4, 10)
Expand All @@ -26,27 +31,7 @@
#'
#' # Or by specifying the width of the bins
#' d + geom_bin_2d(binwidth = c(0.1, 0.1))
geom_bin_2d <- function(mapping = NULL, data = NULL,
stat = "bin2d", position = "identity",
...,
na.rm = FALSE,
show.legend = NA,
inherit.aes = TRUE) {

layer(
data = data,
mapping = mapping,
stat = stat,
geom = GeomTile,
position = position,
show.legend = show.legend,
inherit.aes = inherit.aes,
params = list2(
na.rm = na.rm,
...
)
)
}
geom_bin_2d <- boilerplate(GeomTile, stat = "bin2d")

#' @export
#' @rdname geom_bin_2d
Expand Down
24 changes: 1 addition & 23 deletions R/geom-col.R
Original file line number Diff line number Diff line change
@@ -1,28 +1,6 @@
#' @export
#' @rdname geom_bar
geom_col <- function(mapping = NULL, data = NULL,
position = "stack",
...,
just = 0.5,
na.rm = FALSE,
show.legend = NA,
inherit.aes = TRUE) {

layer(
data = data,
mapping = mapping,
stat = "identity",
geom = GeomCol,
position = position,
show.legend = show.legend,
inherit.aes = inherit.aes,
params = list2(
just = just,
na.rm = na.rm,
...
)
)
}
geom_col <- boilerplate(GeomBar, position = "stack", just = 0.5)

#' @rdname ggplot2-ggproto
#' @format NULL
Expand Down
Loading
Loading