-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented S7 by swapping the rate
class and subclasses from S3
#1154
Open
VisruthSK
wants to merge
8
commits into
tidyverse:main
Choose a base branch
from
VisruthSK:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 2, 2024
-
Started work on S7 implementation.
Need to update tests, documentation. Note that order of arguments are different for subclasses in the current structure--change that.
Configuration menu - View commit details
-
Copy full SHA for 5b8067d - Browse repository at this point
Copy the full SHA 5b8067dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e2a46d0 - Browse repository at this point
Copy the full SHA e2a46d0View commit details
Commits on Nov 3, 2024
-
Rough implementation of S7 with caveats
1. Very ugly way to override super's max_times in rate_delay 2. Changed test cases a bit to correspond with new S7 syntax, but getting random errors so need to look into more
Configuration menu - View commit details
-
Copy full SHA for db1006e - Browse repository at this point
Copy the full SHA db1006eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 240845f - Browse repository at this point
Copy the full SHA 240845fView commit details
Commits on Nov 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cf19ca8 - Browse repository at this point
Copy the full SHA cf19ca8View commit details -
Couple caveats/notes: Needed to change a few tests to match new S7 syntax. Current method of overriding super's default values is inelegant (see `rate_delay`), but functional. Would like to change. Still needs some documentation.
Configuration menu - View commit details
-
Copy full SHA for cbfe418 - Browse repository at this point
Copy the full SHA cbfe418View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa0125c - Browse repository at this point
Copy the full SHA fa0125cView commit details
Commits on Nov 8, 2024
-
Changed class construction to conform with new API. Removed default values in properties as they are listed in constructors.
Configuration menu - View commit details
-
Copy full SHA for 682bbc8 - Browse repository at this point
Copy the full SHA 682bbc8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.