Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented S7 by swapping the rate class and subclasses from S3 #1154

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Commits on Nov 2, 2024

  1. Started work on S7 implementation.

    Need to update tests, documentation. Note that order of arguments are different for subclasses in the current structure--change that.
    VisruthSK committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    5b8067d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e2a46d0 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2024

  1. Rough implementation of S7 with caveats

    1. Very ugly way to override super's max_times in rate_delay
    
    2. Changed test cases a bit to correspond with new S7 syntax, but getting random errors so need to look into more
    VisruthSK committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    db1006e View commit details
    Browse the repository at this point in the history
  2. Typo

    VisruthSK committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    240845f View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Configuration menu
    Copy the full SHA
    cf19ca8 View commit details
    Browse the repository at this point in the history
  2. Converted purrr to S7

    Couple caveats/notes:
    
    Needed to change a few tests to match new S7 syntax.
    
    Current method of overriding super's default values is inelegant (see `rate_delay`), but functional. Would like to change.
    
    Still needs some documentation.
    VisruthSK committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    cbfe418 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fa0125c View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Updated to S7 0.2.0

    Changed class construction to conform with new API. Removed default values in properties as they are listed in constructors.
    VisruthSK committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    682bbc8 View commit details
    Browse the repository at this point in the history