Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on NetBSD #760

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Fix compilation on NetBSD #760

merged 2 commits into from
Feb 26, 2025

Conversation

gaborcsardi
Copy link
Member

NetBSD has wcstombs_l(), but it does not have
uselocale().

NetBSD has wcstombs_l(), but it does not have
uselocale().
@jennybc
Copy link
Member

jennybc commented Oct 25, 2024

This is a generated file, yeah? Do you have any thoughts about that aspect?

@gaborcsardi
Copy link
Member Author

Oh, sorry, I didn't notice. How is it generated?

@jennybc
Copy link
Member

jennybc commented Feb 12, 2025

How is it generated?

With configure, in libxls:

https://github.com/libxls/libxls?tab=readme-ov-file#installation

But we have certainly been known to layer manual tweaks on top of that result.

@jennybc jennybc merged commit 98c8ec8 into tidyverse:main Feb 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants