fix and unify small issues #236
Conversation
| @@ -47,7 +48,7 @@ ggplot(aes(x = Sepal.Width, y = Sepal.Length, color = Species)) + | |||
| ) | |||
|
|
|||
| # Bad | |||
| ggplot(aes(x = Sepal.Width, y = Sepal.Length, color = Species)) + | |||
| iris |> ggplot(aes(x = Sepal.Width, y = Sepal.Length, color = Species)) + | |||
There was a problem hiding this comment.
Better to make the only 'bad' aspect the one about arguments on a long line.
| iris |> ggplot(aes(x = Sepal.Width, y = Sepal.Length, color = Species)) + | |
| iris |> | |
| ggplot(aes(x = Sepal.Width, y = Sepal.Length, color = Species)) + |
| @@ -32,12 +32,12 @@ Avoid using the pipe when: | |||
| # Good | |||
| iris |> | |||
| summarize(across(where(is.numeric), mean), .by = Species) |> | |||
| pivot_longer(-Species, names_to = "measure", values_to = "value") |> | |||
| pivot_longer(!Species, names_to = "measure", values_to = "value") |> | |||
There was a problem hiding this comment.
Does - no longer work? Is it discouraged?
There was a problem hiding this comment.
it works, but I feel ! would fit better since e.g. ?dplyr::select advertises ! for taking the complement of a set of variables
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| ## Naming | |||
|
|
|||
| As well as following the general advice for [object names], strive to use verbs for function names: | |||
| As well as following the general advice for object names in @sec-objectnames, strive to use verbs for function names: | |||
There was a problem hiding this comment.
how does this reference work? I would have expected maybe [object names](syntax#sec-objectnames) instead.
There was a problem hiding this comment.
I've added {#sec-objectnames} accordingly, but linking is also good
| @@ -175,7 +175,7 @@ There are a few exceptions, which should never be surrounded by spaces: | |||
| ) | |||
| ``` | |||
|
|
|||
| Note that single-sided formulas with a complex right-hand side do need a space: | |||
| Note that single-sided formulas with a complex right-hand side do need a space. | |||
There was a problem hiding this comment.
I am fine with : here and above, could you explain more?
There was a problem hiding this comment.
I just thought it would be in the spirit of things to make it uniform for all consecutive bullet points
No description provided.