-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add execution time metrics #1517
Conversation
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
...enario_interpreter/include/openscenario_interpreter/utility/scoped_elapsed_time_recorder.hpp
Outdated
Show resolved
Hide resolved
Failure optional scenariosThis is an experimental check and does not block merging the pull-request. But, please be aware that this may indicate a regression. scenario failed: execution_time_test.junit.xml <failure type="SimulationFailure" message="CustomCommandAction typed "exitFailure" was triggered by the named Conditions {"update time checker", "avoid startup"}: {"update time checker": Is the /simulation/interpreter/execution_time/update (= 0.002308999999999999854644050501) is greaterThan 0.0?}, {"avoid startup": Is the simulation time (= 1.000000000000000222044604925031) is greaterThan 1.000000000000000000000000000000?}" /> |
Failure optional scenariosThis is an experimental check and does not block merging the pull-request. But, please be aware that this may indicate a regression. scenario failed: execution_time_test.junit.xml <failure type="SimulationFailure" message="CustomCommandAction typed "exitFailure" was triggered by the named Conditions {"update time checker", "avoid startup"}: {"update time checker": Is the /simulation/interpreter/execution_time/update (= 0.002164999999999999823890872719) is greaterThan 0.0?}, {"avoid startup": Is the simulation time (= 1.000000000000000222044604925031) is greaterThan 1.000000000000000000000000000000?}" /> |
Failure optional scenariosNote This is an experimental check and does not block merging the pull-request. scenario failed: execution_time_test.junit.xml <failure type="SimulationFailure" message="CustomCommandAction typed "exitFailure" was triggered by the named Conditions {"update time checker", "avoid startup"}: {"update time checker": Is the /simulation/interpreter/execution_time/update (= 0.002955999999999999860306187927) is greaterThan 0.0?}, {"avoid startup": Is the simulation time (= 1.000000000000000222044604925031) is greaterThan 1.000000000000000000000000000000?}" /> |
Failure optional scenariosNote This is an experimental check and does not block merging the pull-request. scenario failed: execution_time_test.junit.xml <failure type="SimulationFailure" message="CustomCommandAction typed "exitFailure" was triggered by the named Conditions {"update time checker", "avoid startup"}: {"update time checker": Is the /simulation/interpreter/execution_time/update (= 0.002618000000000000101335606573) is greaterThan 0.0?}, {"avoid startup": Is the simulation time (= 1.000000000000000222044604925031) is greaterThan 1.000000000000000000000000000000?}" /> |
This reverts commit 30e525c.
This reverts commit 603273f.
Failure optional scenariosNote This is an experimental check and does not block merging the pull-request. scenario failed: execution_time_test <failure type="SimulationFailure" message="CustomCommandAction typed "exitFailure" was triggered by the named Conditions {"update time checker", "avoid startup"}: {"update time checker": Is the /simulation/interpreter/execution_time/update (= 0.002360000000000000118516307879) is greaterThan 0.0?}, {"avoid startup": Is the simulation time (= 1.000000000000000222044604925031) is greaterThan 1.000000000000000000000000000000?}" /> |
Failure optional scenariosNote This is an experimental check and does not block merging the pull-request. scenario failed: execution_time_test <failure type="SimulationFailure" message="CustomCommandAction typed "exitFailure" was triggered by the named Conditions {"update time checker", "avoid startup"}: {"update time checker": Is the /simulation/interpreter/execution_time/update (= 0.002327000000000000075328632221) is greaterThan 0.0?}, {"avoid startup": Is the simulation time (= 1.000000000000000222044604925031) is greaterThan 1.000000000000000000000000000000?}" /> |
This reverts commit 7d343c5.
|
Description
Abstract
This pull-request adds computation time metrics for...
Additionally, this pull-request added test scenario that has execution time conditions.
Background
Previously, scenario_simulator_v2 simply dispaly a log like below if the main loop is timed out:
This pull-reuqest has been made to allow for more detailed analysis.
Details
added metrics topics
/simulation/interpreter/execution_time/evaluate
/simulation/interpreter/execution_time/update
traffic_simulator
/simulation/interpreter/execution_time/output
optional scenarios in workflow
This pull-request added
execution_time_test.yaml
, but the execution time and the scenario result are flaky.Off cource, greater execution time threshold make the scenarios stable.
But the greater the threshold, the lesshoh value there is in the scenario.
In this pull-request, I prepare optional scenario workflows for effective but flaky scenarios.
The scenario failures don't affect CI result, but report the result and error messages by comment as below.
References
Regression Test: OK
Destructive Changes
None
Known Limitations
None