Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete unnecessary target branch filter in workflow trigger #1519

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Jan 30, 2025

Description

Abstract

This pull-request is deleting unnecessary target branch filter in workflow trigger

Background

When adding new features or refactorings that require multiple pull requests, the target branch is often set to something other than master.
There is no reason to exclude such cases from CI.

Details

This pull-request does not change any code.
So, no regression tests are executed.

The workflows below are not fixed because it makes sense to narrow down the target branch to master.

  • .github/workflows/CheckBranchUpToDate.yaml
  • .github/workflows/CheckLabel.yaml
  • .github/workflows/Release.yaml

References

None

Destructive Changes

None

Known Limitations

None

Copy link

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@HansRobo HansRobo added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Jan 30, 2025
@HansRobo HansRobo marked this pull request as ready for review January 30, 2025 08:14
@HansRobo HansRobo requested a review from hakuturu583 January 30, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant