Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gui tests for suspend, lock and unlock #185

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leivos-unikie
Copy link
Collaborator

No description provided.

@leivos-unikie leivos-unikie marked this pull request as draft December 4, 2024 09:53
@leivos-unikie leivos-unikie marked this pull request as ready for review December 5, 2024 12:14
FAIL Failed to lock the screen
END

GUI Unlock
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the name of this keyword as there already is keyword "Gui Unlock"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. There was some inconsistency in those test case names. I made decision to have GUI preposition in those power menu test case names and remove them from the resource keyword names.

@leivos-unikie leivos-unikie force-pushed the gui_suspend_test branch 2 times, most recently from 14f0ee9 to 8f1d555 Compare December 20, 2024 14:17
Comment on lines 103 to 104
[Documentation] Logout via gui icon and verify that desktop is not available
[Tags] lenovo-x1 SP-T149 logout
Connect to VM if not already connected gui-vm
GUI Log out
Log out
Verify logout iterations=5
Run Keyword If ${LOGGED_IN_STATUS} FAIL Logout failed. Desktop still detected after 5 sec.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this keyword depend on the previous one? Tests should be independent. If previous test fails it will affect this test also. I would suggest to check log in and log out inside one test

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All GUI tests (except GUI Log in) depend on the system being in logged in state. Thus log in is executed and verified already in GUI suite setup.

However, I can combine GUI Log in and GUI log out into single test case.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reboot test the logged in state is lost so GUI log out test indeed depends on GUI log in test.

@leivos-unikie leivos-unikie force-pushed the gui_suspend_test branch 2 times, most recently from e23dd2e to f16d930 Compare January 3, 2025 09:17
Marked power menu gui test cases with GUI preposition
and removed GUI from the resource keyword names.

Combined GUI Log in and GUI Log out into a single test
case.

Signed-off-by: Samuli Leivo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants