Network update and GIVC TLS #915
Open
+427
−417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbssrc
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
mbssrc
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
dmitry-erin
reviewed
Dec 10, 2024
mbssrc
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
mbssrc
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
mbssrc
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
mbssrc
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
Updates: - update flake inputs: givc, ctrl-panel Changes to networking: - auto-generate IP and MAC addresses - remove 'debug' network from ghaf. We can simply remove the host from network in release and facilitate communication over mem share Changes to givc: - enable tls - enable multiple admin service interfaces - centralize givc-cli arguments across ghaf Signed-off-by: Manuel Bluhm <[email protected]>
mbssrc
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
humaidq-tii
requested changes
Jan 20, 2025
| }; | ||
| type = mkOption { | ||
| description = "Type of the ghaf component. One of 'host', 'system-vm', or 'app-vm'."; | ||
| type = types.str; |
There was a problem hiding this comment.
Makes sense to use lib.types.enum here.
| config = { | ||
|
|
||
| # Populate the shared namespace | ||
| ghaf = optionalAttrs (hasAttr "microvm" config) { |
There was a problem hiding this comment.
Would hasAttrByPath ["microvm" "vms"] config make this more readable? Instead of the two checks.
| }; | ||
| port = mkOption { | ||
| description = "Port of admin server"; | ||
| type = types.str; |
| }; | ||
| protocol = mkOption { | ||
| description = "Protocol of admin server"; | ||
| type = types.str; |
There was a problem hiding this comment.
types.enum here would make sense.
| @@ -46,11 +46,17 @@ let | |||
| inherit (config.ghaf.qemu) audiovm; | |||
| }; | |||
|
|
|||
| # Common namespace to pass parameters at built-time from host to VMs | |||
| commonModule = { | |||
| config.ghaf.common = config.ghaf.common; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This patch re-works the networking and enables TLS for GIVC.
Updates
Changes to networking
the host from network in release and facilitate communication
over mem share
Note that
Changes to givc
Checklist for things done
x86_64aarch64riscv64make-checksand it passesnixos-rebuild ... switchInstructions for Testing