-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable nix tooling #930
base: main
Are you sure you want to change the base?
Disable nix tooling #930
Conversation
3045be2
to
1413eb9
Compare
1413eb9
to
8dac282
Compare
8dac282
to
15ea8ab
Compare
Rebased to latest. |
Tested debug and release disk image on Lenovo-X1 Lenovo-X1 release image
Lenovo-X1 debug image
|
Tested that release-installer succeeds to install ghaf release version. |
Tested debug and release disk image on Orin AGX Orin AGX release image:
Tried to create the release image according the https://ghaf-jenkins-controller-prod.northeurope.cloudapp.azure.com/job/ghaf-release-pipeline/2/ from October 2024, but there was no terminal available either. Rumors told that last time the terminal was seen on release image in summer 2024. Orin AGX debug image: |
15ea8ab
to
b1466e6
Compare
@johannarautanen and @leivos-unikie , please test it again. I have re-based it and fixed the issue. |
Tested again on lenovo-x1 Debug image built with the change (nix-setup disabled) imitating release image
Debug image
|
- Disable nix tooling if development setup is not enabled - Indirectly disables nix tooling in release build - Enable automatic garbage collection in ghaf-host only Signed-off-by: Ganga Ram <[email protected]>
b1466e6
to
9e93776
Compare
Failed ghaf-pre-merge-pipeline builds 326 and 329 are not related to this PR. There was a glitch in the pre-merge-pipeline itself. These failed builds do not prevent merging this PR. |
Description of changes
- Indirectly disables nix tooling in release build
https://jira.tii.ae/browse/SSRCSP-3457
Checklist for things done
x86_64
aarch64
riscv64
make-checks
and it passesnixos-rebuild ... switch
Instructions for Testing
In release build, no nix commands should be available, nix daemon should not be running.
- As Terminal is not available in release flavor, disable nix-setup in
./modules/common/profiles/debug.nix
(to imitate release)nix-setup.enable = false;
In debug build nix daemon should be running in all VMs and automatic garbage collection should be available only in host.
If automatic garbaze collection is enabled 'systemctl list-timers' should list 'nix-gc' also