Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flake-inputs] Ghafpkgs: update to the latest version #936

Merged
merged 1 commit into from
Dec 20, 2024
Merged

[Flake-inputs] Ghafpkgs: update to the latest version #936

merged 1 commit into from
Dec 20, 2024

Conversation

baz2142
Copy link
Contributor

@baz2142 baz2142 commented Dec 18, 2024 •
edited
Loading

Description of changes

[Flake-inputs] Ghafpkgs: update to the latest version

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  1. Check if AudioControl works the same
  2. Done

@baz2142 baz2142 temporarily deployed to internal-build-workflow December 18, 2024 10:55 — with GitHub Actions Inactive
@baz2142 baz2142 self-assigned this Dec 18, 2024
@baz2142 baz2142 force-pushed the audio-control-dbus-audio-service-v2-plus-icon branch from feff9ce to 9dc8c20 Compare December 18, 2024 14:31
@baz2142 baz2142 temporarily deployed to internal-build-workflow December 18, 2024 14:31 — with GitHub Actions Inactive
@baz2142 baz2142 force-pushed the audio-control-dbus-audio-service-v2-plus-icon branch from 9dc8c20 to dac3b52 Compare December 18, 2024 15:13
@baz2142 baz2142 temporarily deployed to internal-build-workflow December 18, 2024 15:13 — with GitHub Actions Inactive
@baz2142 baz2142 force-pushed the audio-control-dbus-audio-service-v2-plus-icon branch from dac3b52 to 8c48aed Compare December 18, 2024 15:17
@baz2142 baz2142 temporarily deployed to internal-build-workflow December 18, 2024 15:17 — with GitHub Actions Inactive
@baz2142 baz2142 changed the title [Desktop] Graphics: add audio control button [Flake-inputs] Ghafpkgs: update to the latest version Dec 18, 2024
@baz2142 baz2142 marked this pull request as ready for review December 18, 2024 15:28
@brianmcgillion brianmcgillion merged commit f500bec into tiiuae:main Dec 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

@humaidq-tii humaidq-tii Awaiting requested review from humaidq-tii

Assignees

@baz2142 baz2142

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baz2142 @brianmcgillion