-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom PAM rule for desktop login #939
Open
mbssrc
wants to merge
1
commit into
tiiuae:main
Choose a base branch
from
mbssrc:fix-login
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+67
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbssrc
temporarily deployed
to
internal-build-workflow
December 19, 2024 13:27 — with
GitHub Actions
Inactive
mbssrc
temporarily deployed
to
internal-build-workflow
December 21, 2024 14:01 — with
GitHub Actions
Inactive
mbssrc
temporarily deployed
to
internal-build-workflow
December 21, 2024 14:18 — with
GitHub Actions
Inactive
brianmcgillion
approved these changes
Dec 21, 2024
Tested on Lenovo-X1 ( Issues:
Working:
Tested on Orin-AGX and Orin-NX
|
milva-unikie
added
Tested on Orin AGX
This PR has been tested on NVIDIA Jetson AGX Orin
Tested on Orin NX
This PR has been tested on NVIDIA Jetson NX Orin
bug on Lenovo X1 Carbon
Issues found on Lenovo X1 Carbon while checking this PR
and removed
Needs Testing
CI Team to pre-verify
labels
Jan 7, 2025
- remove fprint auth from greetd as user home needs decryption - add custom rule to require users to be in group 'video', preventing admin login on GUI - remove older 'desktop' group in favor of 'video' - fix user creation script to disallow creating user duplicates - fix user creation script to allow '-' characters in name - move ollama persistent directory to service, removing failing ollama user/group setting - move XDG parameters from gui-vm to labc config Signed-off-by: Manuel Bluhm <[email protected]>
mbssrc
temporarily deployed
to
internal-build-workflow
January 7, 2025 14:29 — with
GitHub Actions
Inactive
Fixed with b3b1363. |
mbssrc
added
Needs Testing
CI Team to pre-verify
and removed
bug on Lenovo X1 Carbon
Issues found on Lenovo X1 Carbon while checking this PR
labels
Jan 7, 2025
Cameras work! Camera tests in test-automation will need a small change, pr for that is open tiiuae/ci-test-automation#205 |
milva-unikie
added
Tested on Lenovo X1 Carbon
This PR has been tested on Lenovo X1 Carbon
and removed
Needs Testing
CI Team to pre-verify
labels
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Tested on Lenovo X1 Carbon
This PR has been tested on Lenovo X1 Carbon
Tested on Orin AGX
This PR has been tested on NVIDIA Jetson AGX Orin
Tested on Orin NX
This PR has been tested on NVIDIA Jetson NX Orin
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR includes the following changes and fixes:
greetd
as user home needs decryptionvideo
, preventingadmin login on GUI. Still works for AGX/NX with
createHome
option.user/group setting, adding guard for launcher
This should also fix SRCSP-5891. The user is now not asked for fingerprint
during login, which won't work as the home folder must be decrypted with key derived from users password.
Does not address multiple error messages when entering wrong password on lock-screen.
Checklist for things done
x86_64
aarch64
riscv64
make-checks
and it passesnixos-rebuild ... switch
Tested on x1 and agx.
Instructions for Testing
ghaf
as user