Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fix for invalid var name #1

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Doc fix for invalid var name #1

merged 1 commit into from
Mar 10, 2025

Conversation

benkeen
Copy link
Contributor

@benkeen benkeen commented Mar 10, 2025

Great lib. We can probably use this, we do similar workarounds to speed up updates.

This is just a minor doc fix.

@CLAassistant
Copy link

CLAassistant commented Mar 10, 2025

CLA assistant check
All committers have signed the CLA.

@@ -15,7 +15,7 @@ export function getSquared(length): number {
}
```

The compiler does not provide the best validation for this function, because the type of `a` is not checked; it is treated as the `any` type. With newer versions of TypeScript, you can enable [noImplicitAny](https://www.typescriptlang.org/tsconfig/noImplicitAny.html) in your **tsconfig.json** file. This way, the compiler insists on declaring `length: number`:
The compiler does not provide the best validation for this function, because the type of `length` is not checked; it is treated as the `any` type. With newer versions of TypeScript, you can enable [noImplicitAny](https://www.typescriptlang.org/tsconfig/noImplicitAny.html) in your **tsconfig.json** file. This way, the compiler insists on declaring `length: number`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benkeen!

@octogonz octogonz merged commit 9ce24a3 into tiktok:main Mar 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants