Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: update golangci #7556

Merged
merged 1 commit into from
Dec 15, 2023
Merged

makefile: update golangci #7556

merged 1 commit into from
Dec 15, 2023

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Dec 15, 2023

What problem does this PR solve?

Issue Number: Close #7551

test in HuSharp#3

What is changed and how does it work?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

None.

Signed-off-by: husharp <[email protected]>
Copy link
Contributor

ti-chi-bot bot commented Dec 15, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 15, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and JmPotato December 15, 2023 09:07
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 15, 2023
@HuSharp HuSharp requested review from lhy1024 and removed request for disksing December 15, 2023 09:13
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #7556 (14fdaa3) into master (f51f913) will decrease coverage by 0.03%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7556      +/-   ##
==========================================
- Coverage   74.65%   74.62%   -0.03%     
==========================================
  Files         454      454              
  Lines       50142    50142              
==========================================
- Hits        37432    37420      -12     
- Misses       9385     9391       +6     
- Partials     3325     3331       +6     
Flag Coverage Δ
unittests 74.62% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 15, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 15, 2023
@bufferflies
Copy link
Contributor

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 15, 2023

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 15, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 14fdaa3

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 15, 2023
@ti-chi-bot ti-chi-bot bot merged commit 8196d84 into tikv:master Dec 15, 2023
27 checks passed
@HuSharp HuSharp deleted the update_golangci branch December 15, 2023 09:27
rleungx added a commit to rleungx/pd that referenced this pull request Jan 25, 2024
* etcdutil, mcs: fix the issue loading label rules is too slow (tikv#7718)

Signed-off-by: lhy1024 <[email protected]>

* ci: run `make check` with longer timeout (tikv#7271)

ref tikv#4399

Signed-off-by: lhy1024 <[email protected]>

* mcs: add a switch to dynamically enable scheduling service (tikv#7595)

ref tikv#5839

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

* schedule: prevent suddenly scheduling (tikv#7714)

ref tikv#7671

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

* makefile: update golangci (tikv#7556)

close tikv#7551

Signed-off-by: husharp <[email protected]>

* fix conflict

Signed-off-by: lhy1024 <[email protected]>

---------

Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: husharp <[email protected]>
Co-authored-by: Ryan Leung <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Co-authored-by: Hu# <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make static is unstable
3 participants