-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keyspace: Asynchronously pre-allocate keyspaces #9019
Conversation
* keyspace: Async create pre-alloc keyspaces Signed-off-by: Ping Yu <[email protected]> * fix ut Signed-off-by: Ping Yu <[email protected]> * fix fmt Signed-off-by: Ping Yu <[email protected]> * create parallel; fix ut Signed-off-by: Ping Yu <[email protected]> * fix lint Signed-off-by: Ping Yu <[email protected]> * fix lint Signed-off-by: Ping Yu <[email protected]> * fix lint Signed-off-by: Ping Yu <[email protected]> * fix ut; set fast-fail to false Signed-off-by: Ping Yu <[email protected]> * fix ut Signed-off-by: Ping Yu <[email protected]> * fix ut Signed-off-by: Ping Yu <[email protected]> * fix data race Signed-off-by: Ping Yu <[email protected]> * increase concurrency Signed-off-by: Ping Yu <[email protected]> * wait keyspaces created Signed-off-by: Ping Yu <[email protected]> * add comments Signed-off-by: Ping Yu <[email protected]> * polish Signed-off-by: Ping Yu <[email protected]> * more wait keyspaces Signed-off-by: Ping Yu <[email protected]> * improve wait keyspaces Signed-off-by: Ping Yu <[email protected]> * fix TestKeyspace Signed-off-by: Ping Yu <[email protected]> * fix not determined keyspace id Signed-off-by: Ping Yu <[email protected]> --------- Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (47.82%) is below the target coverage (74.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #9019 +/- ##
==========================================
+ Coverage 75.72% 75.74% +0.01%
==========================================
Files 477 477
Lines 73437 73438 +1
==========================================
+ Hits 55612 55623 +11
+ Misses 14342 14334 -8
+ Partials 3483 3481 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
/retest |
@AmoebaProtozoa: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AmoebaProtozoa, nolouch, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: Close #9022
What is changed and how does it work?
Please note that this PR introduce some changes, including:
So this PR modify some unit test cases to meet the changes.
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note