*: switch to rand v2 #9116
*: switch to rand v2 #9116
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
Signed-off-by: Ryan Leung <[email protected]>
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Linking issues" section in the CONTRIBUTING.md. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9116 +/- ##
==========================================
- Coverage 76.33% 76.33% -0.01%
==========================================
Files 473 473
Lines 71663 71653 -10
==========================================
- Hits 54704 54695 -9
- Misses 13538 13541 +3
+ Partials 3421 3417 -4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
/retest |
| @@ -396,8 +395,7 @@ func SetSource(source RegionSource) RegionCreateOption { | |||
|
|
|||
| // RandomKindReadQuery returns query stat with random query kind, only used for unit test. | |||
| func RandomKindReadQuery(queryRead uint64) *pdpb.QueryStats { | |||
| r := rand.New(rand.NewSource(time.Now().UnixNano())) | |||
There was a problem hiding this comment.
We don't need to create new one after v2?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: Close #xxx
What is changed and how does it work?
Check List
Tests
Release note