Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix the flaky test TestGetPeers #9121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bufferflies
Copy link
Contributor

What problem does this PR solve?

Issue Number: Close #9120

What is changed and how does it work?

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

None.

Signed-off-by: 童剑 <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 6, 2025
Copy link
Contributor

ti-chi-bot bot commented Mar 6, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Mar 6, 2025
@bufferflies bufferflies marked this pull request as ready for review March 6, 2025 12:34
Copy link
Contributor

ti-chi-bot bot commented Mar 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from bufferflies, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 6, 2025
@bufferflies bufferflies added require-LGT1 Indicates that the PR requires an LGTM. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 7, 2025
Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2025

@bufferflies: You cannot manually add or delete the reviewing state labels, only I and the tursted members have permission to do so.

In response to adding label named needs-1-more-lgtm.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.28%. Comparing base (bdd857e) to head (f3587c1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9121      +/-   ##
==========================================
- Coverage   76.31%   76.28%   -0.04%     
==========================================
  Files         473      473              
  Lines       71975    71975              
==========================================
- Hits        54926    54903      -23     
- Misses      13612    13625      +13     
- Partials     3437     3447      +10     
Flag Coverage Δ
unittests 76.28% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestGetPeers is flaky
1 participant