Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add failed_regions_id for scatter regions response #9167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add failed_regions_id for scatter regions response #9167

wants to merge 1 commit into from
+3,439 −24

Conversation

GMHDBJD
Copy link

@GMHDBJD GMHDBJD commented Mar 24, 2025

What problem does this PR solve?

Issue Number: Close #9088

What is changed and how does it work?

  • add failed_regions_id for scatter region response, so client can retry for the failed regions.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Mar 24, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cabinfeverb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. dco-signoff: no Indicates the PR's author has not signed dco. labels Mar 24, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 24, 2025

Hi @GMHDBJD. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 24, 2025

Welcome @GMHDBJD!

It looks like this is your first PR to tikv/pd 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to tikv/pd. 😃

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 24, 2025

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 5c8271b add failed_regions_id for scatter regions response

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 24, 2025
JmPotato
JmPotato reviewed Mar 27, 2025
View reviewed changes
Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better add test cases also.

pkg/mcs/scheduling/server/grpc_service.go
@@ -216,6 +216,7 @@ func (s *Service) ScatterRegions(_ context.Context, request *schedulingpb.Scatte
return &schedulingpb.ScatterRegionsResponse{Header: header}, nil
}
percentage := 100
var failedRegionsID []uint64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var failedRegionsID []uint64
failedRegionsID := make([]uint64, 0, len(failures))

bufferflies
bufferflies reviewed Mar 31, 2025
View reviewed changes
server/grpc_service.go
@@ -2550,16 +2552,18 @@ func (s *GrpcServer) SplitAndScatterRegions(ctx context.Context, request *pdpb.S
RegionsId: newRegionIDs,
SplitFinishedPercentage: uint64(splitFinishedPercentage),
ScatterFinishedPercentage: uint64(scatterFinishedPercentage),
FailedRegionsId: failedRegionsID,
}, nil
}

// scatterRegions add operators to scatter regions and return the processed percentage and error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to add the description for the new response.

bufferflies
bufferflies reviewed Mar 31, 2025
View reviewed changes
server/grpc_service.go
}
percentage := 100
var failedRegionsID []uint64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var failedRegionsID []uint64
var failedRegionIDs []uint64

bufferflies
bufferflies reviewed Mar 31, 2025
View reviewed changes
Copy link
Contributor

@bufferflies bufferflies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato left review comments

@bufferflies bufferflies bufferflies left review comments

Assignees
No one assigned
Labels
dco-signoff: no Indicates the PR's author has not signed dco. do-not-merge/needs-triage-completed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ScatterRegions not returning which region(s) are failed to scatter
3 participants
@GMHDBJD @JmPotato @bufferflies