Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: increase the default lease #9173

Merged
merged 2 commits into from
Apr 10, 2025
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Apr 1, 2025

What problem does this PR solve?

Issue Number: Close #9156.

What is changed and how does it work?

According to the maintainer's comment in etcd-io/etcd#18091 (reply in thread). It is not recommended to use a short lease, which is less than 3s. I think we also need to change the default lease.

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2025
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.73%. Comparing base (9092ccc) to head (b8e9c33).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9173   +/-   ##
=======================================
  Coverage   75.72%   75.73%           
=======================================
  Files         477      477           
  Lines       73437    73438    +1     
=======================================
+ Hits        55612    55616    +4     
+ Misses      14342    14340    -2     
+ Partials     3483     3482    -1     
Flag Coverage Δ
unittests 75.73% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rleungx rleungx requested review from JmPotato and nolouch April 7, 2025 06:51
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 7, 2025
@nolouch
Copy link
Contributor

nolouch commented Apr 7, 2025

Could you add more comments about the reason?

@lhy1024
Copy link
Contributor

lhy1024 commented Apr 8, 2025

Could you add more comments about the reason?

It seems to be from the discussion of etcd community

@rleungx
Copy link
Member Author

rleungx commented Apr 8, 2025

Could you add more comments about the reason?

Add a description, PTAL.

@bufferflies
Copy link
Contributor

bufferflies commented Apr 9, 2025

I read the ahrtr answer about the TTL, he suggests the TTL should be less than 5s.

You need to analyze the trace of the write/put operation, to figure out which step consumed most of the time.
disk I/O and network connectivity are important to etcd, this looks likes an environment issue which you need to resolve.
As mentioned previously, it isn't recommended to create lease with short TTL (e.g. < 5s), because obviously it may be affected by either server side or client side delay.

so why increasing the TTL?

@JmPotato
Copy link
Member

JmPotato commented Apr 9, 2025

As mentioned previously, it isn't recommended to create lease with short TTL (e.g. < 5s)

I think what he means here is better setting TTL greater than or equal to 5 seconds.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 9, 2025
Copy link
Contributor

ti-chi-bot bot commented Apr 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-07 07:41:24.906183708 +0000 UTC m=+2069378.590419803: ☑️ agreed by JmPotato.
  • 2025-04-09 10:46:58.449060431 +0000 UTC m=+2253312.133296522: ☑️ agreed by bufferflies.

Copy link
Contributor

ti-chi-bot bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, JmPotato, niubell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 10, 2025
@ti-chi-bot ti-chi-bot bot merged commit aa28f66 into tikv:master Apr 10, 2025
25 checks passed
@rleungx rleungx deleted the increase-lease branch April 10, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase the default lease configuration
6 participants