-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: increase the default lease #9173
Conversation
Signed-off-by: Ryan Leung <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9173 +/- ##
=======================================
Coverage 75.72% 75.73%
=======================================
Files 477 477
Lines 73437 73438 +1
=======================================
+ Hits 55612 55616 +4
+ Misses 14342 14340 -2
+ Partials 3483 3482 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Could you add more comments about the reason? |
It seems to be from the discussion of etcd community |
Add a description, PTAL. |
I read the ahrtr answer about the TTL, he suggests the TTL should be less than 5s.
so why increasing the TTL? |
I think what he means here is better setting TTL greater than or equal to 5 seconds. |
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies, JmPotato, niubell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: Close #9156.
What is changed and how does it work?
According to the maintainer's comment in etcd-io/etcd#18091 (reply in thread). It is not recommended to use a short lease, which is less than 3s. I think we also need to change the default lease.
Check List
Tests
Release note