Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Keyspace cleaning #9182

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[WIP] Keyspace cleaning #9182

wants to merge 2 commits into from
+359 −4

Conversation

AmoebaProtozoa
Copy link
Contributor

What problem does this PR solve?

Issue Number: Ref #6067

What is changed and how does it work?

This PR added the basic keyspace cleaning framework and some configurable options to keyspace module.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has the configuration change

Side effects

Related changes

Release note

None.

@AmoebaProtozoa
init commit
ad1f072 
Signed-off-by: AmoebaProtozoa <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Apr 7, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign benmeadowcroft, rleungx for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Apr 7, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 7, 2025

Hi @AmoebaProtozoa. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 7, 2025
ystaticy
ystaticy reviewed Apr 7, 2025
View reviewed changes
pkg/keyspace/gc.go Outdated
@@ -0,0 +1,189 @@
// Copyright 2023 TiKV Project Authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2025

@AmoebaProtozoa
fix license
98bb8e6 
Signed-off-by: AmoebaProtozoa <[email protected]>
ystaticy
ystaticy reviewed Apr 7, 2025
View reviewed changes
pkg/keyspace/gc.go
gcLifeTime time.Duration
}

// newGCWorker returns a newGCWorker.
Copy link
Contributor

@ystaticy ystaticy Apr 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduce the concept of 'archive' instead of calling it GC to prevent other developers from confusing this GC with MVCC GC

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, do not use the concept of 'GC' when archiving a keyspace, and the naming of safepoint variables should include a prefix to indicate what operation the safepoint corresponds to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, sounds good, will use cleaning & archiving instead of gc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ystaticy ystaticy ystaticy left review comments

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmoebaProtozoa @ystaticy