Add fixed octave for block+fnum systems #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't implemented in SAA1099, despite also being block+fnum system, as there are no benefits from it
tildearrow
requested changes
Jan 28, 2025
There was a problem hiding this comment.
There are situations in where the user may desire changing the block through an effect. Accessing the instrument won't work in that case.
Since block is part of DivInstrumentFM, and every FM chip channel has a state member (which is a DivInstrumentFM), you can try using that instead.
tildearrow
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been sitting for months now...
Allows forcing a block (octave) number to be a constant number regardless of pitch. This has a use mostly in SSG-EG where a constant envelope frequency is needed.
Requires an extra instrument field and a version number bump which is already done.