Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous line breaks in KJV verses #187 #188

Merged
merged 2 commits into from
May 14, 2024

Conversation

abbasou
Copy link
Contributor

@abbasou abbasou commented May 12, 2024

Replace .trim method with .replace to remove extraneous line breaks from KJV verses pulled from BibleAPI.

Replace .trim method with .replace to remove extraneous line breaks from KJV verses pulled from BibleAPI.
Copy link
Owner

@tim-hub tim-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question

src/verse/BaseVerseFormatter.ts Outdated Show resolved Hide resolved
@abbasou
Copy link
Contributor Author

abbasou commented May 13, 2024

Total GitHub noob here. Do I need to do some kind of edit from my side, or do you make the proposed changes from your end?

@abbasou
Copy link
Contributor Author

abbasou commented May 13, 2024

Nevermind. I found the Commit Suggestion button. Lol

@tim-hub
Copy link
Owner

tim-hub commented May 14, 2024

Thanks

@tim-hub tim-hub merged commit 1f5cd6e into tim-hub:master May 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants