Remove backward direction for ABI tests #7495
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkindahl
force-pushed
the
fix-abi-checks
branch
from
720a1ab
to
1a67a07
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7495 +/- ##
==========================================
+ Coverage 80.06% 82.15% +2.08%
==========================================
Files 190 230 +40
Lines 37181 43188 +6007
Branches 9450 10867 +1417
==========================================
+ Hits 29770 35480 +5710
- Misses 2997 3383 +386
+ Partials 4414 4325 -89 ☔ View full report in Codecov by Sentry. |
|
@mkindahl can u please point to related CI failures? |
Sure. An example is our nightly runs the last few days: https://github.com/timescale/timescaledb/actions/runs/12038215739/job/33563401918 |
Versions of the extension cannot be expected to always work in the backwards direction so we cannot reliably test that builds against later versions of PostgreSQL (e.g., 17.3) work with earlier versions (e.g., 17.0) if new functions are introduced in the later version.
mkindahl
force-pushed
the
fix-abi-checks
branch
from
1a67a07
to
49f31fb
Compare
fabriziomello
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions of the extension cannot be expected to always work in the backwards direction so we cannot reliably test that builds against later versions of PostgreSQL (e.g., 17.3) work with earlier versions (e.g., 17.0) if new functions are introduced in the later version.
Disable-check: force-changelog-file