Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to use custom Query/Mutation/Subscription naming #54

Conversation

justenau
Copy link
Contributor

@justenau justenau commented Apr 6, 2022

This PR solves #27.

During development we also run into issue that our queries and mutations are named RootQuery and RootMutation (which is by the way a very common practice) and this prevents us to use this tool. Renaming them is not an option since the types generated from them are used across many other projects and we can't change them.

I tested these changes with our schema and it works great. Also it's a small, non-breaking change that would solve quite a huge issue so I hope this will become part of the library soon, otherwise the only way to use it is to fork it to our project and add those changes there.

Will be waiting for updates, thanks! 🤞

@timqian
Copy link
Owner

timqian commented Apr 7, 2022

👍👍

@timqian timqian merged commit d003909 into timqian:master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants