Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignored commits feature #114

Closed
wants to merge 1 commit into from

Conversation

allanlw
Copy link

@allanlw allanlw commented Apr 7, 2023

This addresses #113 by adding a new option "ignored_commits_file" that points to a file to contain commit hashes in the same format as blame.ignoreRevsFile that will be ignored during calculation of the most recent update. To the best of my knowledge, it is not possible to ask git log to ignore commits, so this must be done by the plugin.

I've added a basic unit test for the file parser, and an integration test to validate the commit ignoring behavior.

I've tested this on my own repository and verified that it behaves as expected.

pyflakes shows no new issues. pytest shows no changed lines without coverage.

@timvink
Copy link
Owner

timvink commented Apr 12, 2023

Thanks! Well done on figuring this one out. Too bad we couldn't find something more elegant with using git internals like what is possible for git log.

I have some comments, and there are some failing unit tests. Please have a look :)

@allanlw
Copy link
Author

allanlw commented Apr 19, 2023

I believe that the tests failed because of this codecov issue: https://about.codecov.io/blog/message-regarding-the-pypi-package/

Could you please re-run them? Then I can address any test failures along with the refactoring you requested all at once.

@timvink
Copy link
Owner

timvink commented Mar 4, 2025

I've addressed the comments and fixed the unit tests in #157 , will release soon

@timvink timvink closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants