Scan multiple instances of same device type in the system #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaval-rivos
force-pushed
the
dev/dhaval/pcie-all-instance-enum
branch
2 times, most recently
from
4efcbd8 to
5676898
Compare
src/lib.rs
Outdated
| ops: &PciEcamCfgOps, | ||
| vendor_id: u16, | ||
| device_id: u16, | ||
| ) -> Vec<Device> { |
There was a problem hiding this comment.
Can we return a DeviceIterator by applying filter operation on lines 1501-1503 instead of pushing to a Vec? This library does not have any dependency on alloc crate and was wondering if we could keep it that way?
src/lib.rs
Outdated
| @@ -1484,6 +1487,25 @@ pub fn shallow_scan_for_device( | |||
| .find(|&device| device.vendor_id == vendor_id && device.device_id == device_id) | |||
| } | |||
|
|
|||
| // same as shallow_scan_for_device but scans all instances, some devices like | |||
| // RoT have multiple instances within each chiplet, we should find and return all. | |||
There was a problem hiding this comment.
This is a generic library, so let's avoid any specific examples for any design here.
To be used by caller to go over all the instances of pci devices.
dhaval-rivos
force-pushed
the
dev/dhaval/pcie-all-instance-enum
branch
from
5676898 to
5cd77d1
Compare
timw-rivos
reviewed
Jan 2, 2025
| @@ -1484,6 +1484,17 @@ pub fn shallow_scan_for_device( | |||
| .find(|&device| device.vendor_id == vendor_id && device.device_id == device_id) | |||
| } | |||
|
|
|||
| pub fn get_pci_device_iter( | |||
There was a problem hiding this comment.
vendor_id and device_id are unused here, what is the purpose? It seems like you're wanting maybe something like
all_local_devices(Bdf::from_bus(Bus(bus)), ops, Bus(bus + 1)).filter(|dev| dev.vendor_id == vendor_id && dev.device_id == device_id)
which is just adding a filter() call to all_local_devices(). does that need to be in this library? We have users of this library already that use it like:
for dev in pci::all_local_devices(0, &ops)
.filter(|dev| dev.vendor_id == RIVOS_VENDOR_ID && dev.device_id == IOMMU_DEVICE_ID)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.