Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT-3324: Move tinymce to an optional peer dependency #544

Merged
merged 5 commits into from
Jul 19, 2024

Conversation

danoaky-tiny
Copy link
Contributor

@danoaky-tiny danoaky-tiny commented Jul 16, 2024

INT-3324

Changes:

  • The tinymce package is now an optional peer dependency.
  • Imports of tinymce now use import type ... to help prevent accidental usage of tinymce JS code through a direct import in this way.
  • Upgraded dependencies to latest

This would require a major version bump as anybody that's using the provided tinymce (that is currently a dependency) would have their editor break. Although according to our docs this isn't the intended way to self host tinymce, it's still a breaking change.

@FarzadHayat
Copy link
Contributor

FarzadHayat commented Jul 17, 2024

Running yarn lint, I get warning:

yarn run v1.22.22
$ eslint 'src/**/*.ts?(x)'
=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.2.0

YOUR TYPESCRIPT VERSION: 5.5.3

Please only submit bug reports when using the officially supported version.

=============

devDependency "@tinymce/eslint-plugin": "^2.3.1" has it's own devDependency on "@typescript-eslint/typescript-estree": "^5.59.5", see: https://github.com/tinymce/eslint-plugin/blob/main/package.json#L25. Latest version of @typescript-eslint/typescript-estree is v7.16.1. Is this fine?

@danoaky-tiny danoaky-tiny marked this pull request as ready for review July 17, 2024 03:24
@danoaky-tiny danoaky-tiny requested a review from a team as a code owner July 17, 2024 03:24
@danoaky-tiny danoaky-tiny requested review from spocke, hamza0867 and ltrouton and removed request for a team July 17, 2024 03:24
@danoaky-tiny
Copy link
Contributor Author

danoaky-tiny commented Jul 17, 2024

devDependency "@tinymce/eslint-plugin": "^2.3.1" has it's own devDependency on "@typescript-eslint/typescript-estree": "^5.59.5", see: https://github.com/tinymce/eslint-plugin/blob/main/package.json#L25. Latest version of @typescript-eslint/typescript-estree is v7.16.1. Is this fine?

@FarzadHayat Should be fine IMO. I've never had a problem with this warning.

@danoaky-tiny danoaky-tiny merged commit f6b7a13 into main Jul 19, 2024
5 checks passed
@danoaky-tiny danoaky-tiny deleted the feature/INT-3324 branch July 19, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants