INT-3324: Move tinymce to an optional peer dependency #544
+2,617
−3,463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INT-3324
Changes:
tinymce
package is now an optional peer dependency.tinymce
now useimport type ...
to help prevent accidental usage of tinymce JS code through a direct import in this way.This would require a major version bump as anybody that's using the provided tinymce (that is currently a dependency) would have their editor break. Although according to our docs this isn't the intended way to self host tinymce, it's still a breaking change.