Consider ready state of editor for update of disabled prop #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paescuj
requested review from
spocke,
TheSpyder and
ltrouton
and removed request for
a team
|
Anything I can do here? |
|
@TheSpyder Sorry for the ping! The issue as well as the provided fix seem pretty straightforward to me. What can we do to get it over the line? ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a chance that updates of the
disabledprop are ignored when happening before the editor itself is ready.Adding the
readystate ensures the watcher runs again as soon as the editor has been initialized and is actually able to receive an update of the mode.