Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OS Support [C CI] #34

Merged
merged 21 commits into from
Mar 8, 2025
Merged

Improve OS Support [C CI] #34

merged 21 commits into from
Mar 8, 2025

Conversation

TheMrSheldon
Copy link
Member

@TheMrSheldon TheMrSheldon commented Mar 7, 2025

Added support for the build settings listed below to the C/C++ CI. Items are checked off if we support them or if they are known to be incompatible.

  • Ubuntu 20.04
  • Ubuntu 24.04
  • Windows 2019
  • Windows 2022
  • Windows 2025
  • clang
  • gcc
    • macOS 13: Known issue with gcc and the GitHub macOS 13 runner – wontfix
    • macOS 14
    • macOS 15

Used the builds on ubuntu-20.04 to be released.

@TheMrSheldon TheMrSheldon added enhancement New feature or request c/c++ Related to the C or C++ API or Code labels Mar 7, 2025
@TheMrSheldon TheMrSheldon self-assigned this Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.36%. Comparing base (90a168c) to head (2f7526c).
Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #34   +/-   ##
=========================================
  Coverage     78.36%   78.36%           
  Complexity       20       20           
=========================================
  Files             3        3           
  Lines          1151     1151           
  Branches         53       53           
=========================================
  Hits            902      902           
  Misses          208      208           
  Partials         41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheMrSheldon TheMrSheldon changed the title Improve OS Support Improve OS Support [C CI] Mar 7, 2025
@TheMrSheldon TheMrSheldon marked this pull request as ready for review March 7, 2025 15:21
Copy link
Contributor

@janheinrichmerker janheinrichmerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice changes! I think, the minor comments can be addressed/fixed easily

@TheMrSheldon TheMrSheldon enabled auto-merge (squash) March 7, 2025 19:18
@mam10eks mam10eks disabled auto-merge March 8, 2025 06:30
@mam10eks mam10eks dismissed janheinrichmerker’s stale review March 8, 2025 06:37

As discussed in the chat, we can merge this and create a new ticket to resolve this to release the new version.

@mam10eks mam10eks enabled auto-merge March 8, 2025 06:37
@mam10eks mam10eks self-requested a review March 8, 2025 06:39
@mam10eks mam10eks merged commit 4ec2aa7 into master Mar 8, 2025
98 checks passed
@mam10eks mam10eks deleted the improve_os_support branch March 8, 2025 06:40
@janheinrichmerker janheinrichmerker mentioned this pull request Mar 11, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/c++ Related to the C or C++ API or Code enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants