Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example for testing padding fixes #322

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

andrewkmin
Copy link
Collaborator

@andrewkmin andrewkmin commented Aug 7, 2024

Summary & Motivation

$title

See #321 for context.

How I Tested These Changes

Local

Did you add a changeset?

N/A

If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run pnpm changeset. pnpm changeset will generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).

These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.

Copy link

codesandbox-ci bot commented Aug 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@andrewkmin andrewkmin force-pushed the andrew/padding-fixes branch from 2e4fa27 to 0e269bc Compare August 7, 2024 20:50
@andrewkmin andrewkmin changed the title Andrew/padding fixes testing testing padding fixes Aug 7, 2024
@andrewkmin andrewkmin force-pushed the andrew/padding-fixes-testing branch from 97c1996 to c0f6eec Compare August 7, 2024 23:07
@andrewkmin andrewkmin mentioned this pull request Aug 8, 2024
@andrewkmin andrewkmin changed the title testing padding fixes [do not merge] testing padding fixes Aug 9, 2024
@andrewkmin andrewkmin force-pushed the andrew/padding-fixes branch 2 times, most recently from 2425f82 to c6d7a1e Compare August 14, 2024 00:18
@andrewkmin andrewkmin force-pushed the andrew/padding-fixes-testing branch 2 times, most recently from 63eb2f5 to 641d145 Compare August 14, 2024 18:35
Copy link

socket-security bot commented Aug 14, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@noble/[email protected] None 0 1.57 MB paulmillr
npm/[email protected] network +1 1.77 MB jasonsaayman

View full report↗︎

@andrewkmin andrewkmin changed the title [do not merge] testing padding fixes add example for testing padding fixes Aug 14, 2024
Base automatically changed from andrew/padding-fixes to main August 14, 2024 20:56
@andrewkmin andrewkmin force-pushed the andrew/padding-fixes-testing branch 3 times, most recently from 5ac2345 to 0b78b90 Compare August 19, 2024 18:23
@andrewkmin andrewkmin force-pushed the andrew/padding-fixes-testing branch from 0b78b90 to d531b43 Compare August 19, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant