-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add example for testing padding fixes #322
Open
andrewkmin
wants to merge
7
commits into
main
Choose a base branch
from
andrew/padding-fixes-testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
andrewkmin
force-pushed
the
andrew/padding-fixes
branch
from
August 7, 2024 20:50
2e4fa27
to
0e269bc
Compare
andrewkmin
force-pushed
the
andrew/padding-fixes-testing
branch
from
August 7, 2024 23:07
97c1996
to
c0f6eec
Compare
Merged
andrewkmin
force-pushed
the
andrew/padding-fixes
branch
2 times, most recently
from
August 14, 2024 00:18
2425f82
to
c6d7a1e
Compare
andrewkmin
force-pushed
the
andrew/padding-fixes-testing
branch
2 times, most recently
from
August 14, 2024 18:35
63eb2f5
to
641d145
Compare
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
andrewkmin
changed the title
[do not merge] testing padding fixes
add example for testing padding fixes
Aug 14, 2024
andrewkmin
force-pushed
the
andrew/padding-fixes-testing
branch
3 times, most recently
from
August 19, 2024 18:23
5ac2345
to
0b78b90
Compare
andrewkmin
force-pushed
the
andrew/padding-fixes-testing
branch
from
August 19, 2024 18:30
0b78b90
to
d531b43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
$title
See #321 for context.
How I Tested These Changes
Local
Did you add a changeset?
N/A
If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run
pnpm changeset
.pnpm changeset
will generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.