-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create global UI style/theme #75
Comments
I looked at the I will try updating Material UI, and otherwise I will try adding a |
If upgrading to Material-UI fixes the error then We need to create a new issue since wrapping in a Theme is one way of fixing it. But the current issue description is not just about the error we are seeing. |
@ssciolla Can you provide some estimation here? |
Well, it depends on what this issue is. If it's implementing a global theme, I can estimate that, but fixing the problem you identified may involve updating to Material UI 5, which is a bigger deal, harder to estimate. These should be split into separate issues. |
I am talking about the error, possible fix which I understood as having a global theme, if that is not the case. I feel we need to evaluate if we can live with this error for sometime or upgrade to Material UI. |
Okay, I gave an estimate. I still think that needs to be a separate issue. It's related but not the same as what Chris originally opened this issue about. |
I believe I did some investigating, and that led to some article that led to me to experimenting w/ a theme to eliminate the warning message. |
…e error icon color
Not sure what the correct terminology but we should be using some sort of global theme/style throughout the application.
This seemed to me like something you might implement after having more than one feature so you have an idea of common concepts, though it couldn't hurt to have the framework in place earlier.
Currently each component is composing its own style.
We are using the MUI primary color as #00274C
The text was updated successfully, but these errors were encountered: