-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#265 #75 creating theme and fixing the error icon color #282
#265 #75 creating theme and fixing the error icon color #282
Conversation
…e error icon color
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Couple minor comments for you to consider.
I will note that I did a search for "color: " in client
and there were a number of other hex values, mostly grayscale stuff I think. It would be nice to tidy this up at some point, but it doesn't have to be as part of this issue.
Also, this doesn't introduce a |
I think is fairly simple to do, But what should be that color? Can we do what Myla is doing |
Mmm, maybe check with Janel, but that's probably reasonable. It doesn't need to be done in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Test successful: After I changed the palette colors in theme.ts file (primary, error, warning, success, info), I can verify consistent color changes in all CCM subtask screens. |
Fixes #265, #75
This issue touches all of the features. Based on the Feedback i can add more here or later.