Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#265 #75 creating theme and fixing the error icon color #282

Conversation

pushyamig
Copy link
Contributor

Fixes #265, #75

  1. This issue took a first pass at creating a theme and getting all the generalized styling at one place. We could add more stuff to theme but this is a bare bone implementations
  2. So far error, warn, success and info to users are coming from theme

This issue touches all of the features. Based on the Feedback i can add more here or later.

@pushyamig pushyamig requested a review from ssciolla December 15, 2021 17:17
Copy link
Contributor

@ssciolla ssciolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Couple minor comments for you to consider.

I will note that I did a search for "color: " in client and there were a number of other hex values, mostly grayscale stuff I think. It would be nice to tidy this up at some point, but it doesn't have to be as part of this issue.

@ssciolla
Copy link
Contributor

Also, this doesn't introduce a primary color, which we may want to do before we release.

@pushyamig
Copy link
Contributor Author

Also, this doesn't introduce a primary color, which we may want to do before we release.

I think is fairly simple to do, But what should be that color? Can we do what Myla is doing #00274C

@ssciolla
Copy link
Contributor

Also, this doesn't introduce a primary color, which we may want to do before we release.

I think is fairly simple to do, But what should be that color? Can we do what Myla is doing #00274C

Mmm, maybe check with Janel, but that's probably reasonable. It doesn't need to be done in this PR.

@pushyamig pushyamig requested a review from ssciolla December 16, 2021 17:56
@ssciolla ssciolla added enhancement New feature or request front end Involves changes to the React application or other client-related files usability 🐛 bug Something isn't working labels Dec 16, 2021
Copy link
Contributor

@ssciolla ssciolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pushyamig pushyamig merged commit 7a71dc7 into tl-its-umich-edu:main Dec 16, 2021
@zqian zqian linked an issue Dec 20, 2021 that may be closed by this pull request
@zqian
Copy link
Member

zqian commented Apr 8, 2022

Test successful:

After I changed the palette colors in theme.ts file (primary, error, warning, success, info), I can verify consistent color changes in all CCM subtask screens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working enhancement New feature or request front end Involves changes to the React application or other client-related files usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incase of error view use Red exclamation Create global UI style/theme
3 participants