Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileCheck: add page #15433

Merged
merged 8 commits into from
Jan 7, 2025
Merged

FileCheck: add page #15433

merged 8 commits into from
Jan 7, 2025

Conversation

P2Tree
Copy link
Contributor

@P2Tree P2Tree commented Jan 3, 2025

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers. labels Jan 3, 2025
@tldr-bot

This comment was marked as resolved.

Sign in to view
gutjuri
gutjuri reviewed Jan 3, 2025
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have two comments

pages/common/filecheck.md Outdated Show resolved Hide resolved
pages/common/filecheck.md Outdated Show resolved Hide resolved
gutjuri
gutjuri approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

kbdharun
kbdharun approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, LGTM after this minor suggestion.

pages/common/filecheck.md Outdated Show resolved Hide resolved
@sebastiaanspeck @kbdharun
Update filecheck.md
7229283 
Co-authored-by: K.B.Dharun Krishna <[email protected]>
@kbdharun kbdharun merged commit 26024a1 into tldr-pages:main Jan 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthik-script karthik-script karthik-script approved these changes

@kbdharun kbdharun kbdharun approved these changes

@gutjuri gutjuri gutjuri approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@P2Tree @tldr-bot @gutjuri @kbdharun @karthik-script @sebastiaanspeck