Add SRP (Secure Remote Password) probe #140
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new SRP probe to detect SRP extension support and cipher suites - Test for RFC 5054 compliance regarding missing SRP extension behavior - Add properties: SUPPORTS_SRP_EXTENSION, SRP_CIPHERSUITES, MISSING_SRP_EXTENSION_BUG - Register probe in TlsServerScanner probe list - Include unit and integration tests Fixes #29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation Details
This PR adds:
SrpProbe: New probe class that tests SRP functionalitySUPPORTS_SRP_EXTENSION: Whether the server supports the SRP extensionSRP_CIPHERSUITES: List of supported SRP cipher suitesMISSING_SRP_EXTENSION_BUG: Whether the server incorrectly accepts SRP cipher suites without the SRP extensionThe probe performs two main tests:
unknown_psk_identityalert)Test Plan
Fixes #29