#603 trim final url

tmenier · Apr 27, 2021 · e24ff98 · e24ff98
1 parent 05d0a31
commit e24ff98
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/Test/Flurl.Test/UrlBuilder/UrlBuildingTests.cs b/Test/Flurl.Test/UrlBuilder/UrlBuildingTests.cs
@@ -604,5 +604,11 @@ public void can_append_trailing_slash() {
 			url.AppendPathSegment("///");
 			Assert.AreEqual("https://www.site.com/a/b/c///", url.ToString());
 		}
+
+		[Test]
+		public void url_trims_leading_and_trailing_whitespace() {
+			var url = new Url("  https://www.site.com \t");
+			Assert.AreEqual("https://www.site.com", url.ToString());
+		}
 	}
 }
diff --git a/src/Flurl/Url.cs b/src/Flurl/Url.cs
@@ -140,10 +140,9 @@ public string Fragment {
 		/// <summary>
 		/// Constructs a Url object from a string.
 		/// </summary>
-		/// <param name="baseUrl">The URL to use as a starting point (required)</param>
-		/// <exception cref="ArgumentNullException"><paramref name="baseUrl"/> is <see langword="null" />.</exception>
+		/// <param name="baseUrl">The URL to use as a starting point.</param>
 		public Url(string baseUrl = null) {
-			_originalString = baseUrl;
+			_originalString = baseUrl?.Trim();
 		}
 
 		/// <summary>
@@ -508,7 +507,7 @@ public string ToString(bool encodeSpaceAsPlus) {
 				QueryParams.Any() ? "?" : "",
 				QueryParams.ToString(encodeSpaceAsPlus),
 				Fragment?.Length > 0 ? "#" : "",
-				Fragment);
+				Fragment).Trim();
 		}
 
 		/// <summary>